Skip to content

Commit 569bf05

Browse files
committed
move mw db version map to conf file
1 parent bcbea7c commit 569bf05

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

app/Services/MediaWikiHostResolver.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@ class UnknownDBVersionException extends Exception {}
1616
class UnknownWikiDomainException extends Exception {}
1717

1818
class MediaWikiHostResolver {
19-
// TODO: Move this mapping to a config file so that MW updates do not require code changes here.
20-
/** @var array<string, string> Map of DB version strings to MediaWiki version strings */
21-
private const DB_VERSION_TO_MW_VERSION = [
22-
'mw1.39-wbs1' => '139',
23-
'mw1.43-wbs1' => '143',
24-
];
25-
2619
/**
2720
* @throws UnknownDBVersionException
2821
* @throws UnknownWikiDomainException
@@ -53,8 +46,9 @@ private function getMwVersionForDomain(string $domain): string {
5346

5447
$dbVersion = $wiki->wikiDb->version;
5548

56-
if (array_key_exists($dbVersion, self::DB_VERSION_TO_MW_VERSION)) {
57-
return self::DB_VERSION_TO_MW_VERSION[$dbVersion];
49+
$versionMap = config('mw-db-version-map');
50+
if (array_key_exists($dbVersion, $versionMap)) {
51+
return $versionMap[$dbVersion];
5852
}
5953
throw new UnknownDBVersionException("Unknown DB version '{$dbVersion}' for domain '{$domain}'.");
6054
}

config/mw-db-version-map.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
// TODO: Read from outside of this codebase so that MW updates do not require code changes here.
4+
$versionMap = [
5+
'mw1.39-wbs1' => '139',
6+
'mw1.43-wbs1' => '143',
7+
];
8+
9+
return $versionMap;

0 commit comments

Comments
 (0)