Add missing test cases prior to refactoring

Author: AndrewKostka

tests/Routes/Wiki/DeleteWikiTest.php

@@ -34,4 +34,15 @@ public function testDelete()
             Wiki::withTrashed()->find($wiki->id)->wiki_deletion_reason
         );
     }
+
+    public function testFailOnWrongWikiManager(): void
+    {
+        $userWiki = Wiki::factory()->create();
+        $otherWiki = Wiki::factory()->create();
+        $user = User::factory()->create(['verified' => true]);
+        WikiManager::factory()->create(['wiki_id' => $userWiki->id, 'user_id' => $user->id]);
+        $this->actingAs($user, 'api')
+            ->post('wiki/delete', ['wiki' => $otherWiki->id])
+            ->assertStatus(401);
+    }
 }

tests/Routes/Wiki/DetailsTest.php

@@ -61,6 +61,17 @@ public function testSkipsNonPublicSettings()
         $this->assertEquals(1, $publicSettings[0]['value']);
     }
 
+    public function testFailOnWrongWikiManager(): void
+    {
+        $userWiki = Wiki::factory()->create();
+        $otherWiki = Wiki::factory()->create();
+        $user = User::factory()->create(['verified' => true]);
+        WikiManager::factory()->create(['wiki_id' => $userWiki->id, 'user_id' => $user->id]);
+        $this->actingAs($user, 'api')
+            ->postJson($this->route, ['wiki' => $otherWiki->id])
+            ->assertStatus(403);
+    }
+
     public function testWikiProfile()
     {
         $wiki = Wiki::factory()->create();

tests/Routes/Wiki/LogoUpdateTest.php

@@ -54,4 +54,17 @@ public function testUpdate()
         $this->assertSame(64, $logo->height());
         $this->assertSame(64, $logo->width());
     }
+
+    public function testFailOnWrongWikiManager(): void
+    {
+        $userWiki = Wiki::factory()->create();
+        $otherWiki = Wiki::factory()->create();
+        $user = User::factory()->create(['verified' => true]);
+        WikiManager::factory()->create(['wiki_id' => $userWiki->id, 'user_id' => $user->id]);
+        $file = UploadedFile::fake()
+            ->createWithContent("logo_200x200.png", file_get_contents(__DIR__ . "/../../data/logo_200x200.png"));
+        $this->actingAs($user, 'api')
+            ->post('wiki/logo/update', ['wiki' => $otherWiki->id, 'logo' => $file])
+            ->assertStatus(401);
+    }
 }

tests/Routes/Wiki/SettingUpdateTest.php

@@ -38,18 +38,20 @@ public function testSetInvalidSetting()
           ->assertJsonStructure(['errors' => ['setting']]);
     }
 
-    public function testValidSettingNoWiki()
+    public function testFailOnWrongWikiManager(): void
     {
         $settingName = 'wwExtEnableConfirmAccount';
-
+        $userWiki = Wiki::factory()->create();
+        $otherWiki = Wiki::factory()->create();
         $user = User::factory()->create(['verified' => true]);
+        WikiManager::factory()->create(['wiki_id' => $userWiki->id, 'user_id' => $user->id]);
         $this->actingAs($user, 'api')
-            ->json('POST', str_replace('foo', $settingName, $this->route), [
-            'wiki' => 99856,
-            'setting' => $settingName,
-            'value' => '1',
-          ])
-          ->assertStatus(401);
+            ->postJson(str_replace('foo', $settingName, $this->route), [
+                'wiki' => $otherWiki->id,
+                'setting' => $settingName,
+                'value' => '1'
+            ])
+            ->assertStatus(401);
     }
 
     static public function provideValidSettings()