cleanup: move MW DB Version Map to config file (#1014)

Author: deer-wmde

app/Http/Controllers/Backend/WikiDbVersionController.php

@@ -7,12 +7,6 @@
 use Illuminate\Http\Request;
 
 class WikiDbVersionController extends Controller {
-    // keep in sync with App\Services\MediaWikiHostResolver
-    private const DB_VERSION_TO_MW_VERSION = [
-        'mw1.39-wbs1' => '139',
-        'mw1.43-wbs1' => '143',
-    ];
-
     public function updateWikiDbVersion(Request $request): \Illuminate\Http\JsonResponse {
         $validated = $request->validate([
             'domain' => 'required|string',
@@ -29,7 +23,7 @@ public function updateWikiDbVersion(Request $request): \Illuminate\Http\JsonResp
                 return response()->json(['error' => "No wiki found with domain: '{$domain}'"], 404);
             }
 
-            if (!array_key_exists($targetDbVersion, self::DB_VERSION_TO_MW_VERSION)) {
+            if (!array_key_exists($targetDbVersion, config('mw-db-version-map'))) {
                 return response()->json(['error' => "Invalid database version string: '{$targetDbVersion}'"], 400);
             }
 

app/Services/MediaWikiHostResolver.php

@@ -16,14 +16,6 @@ class UnknownDBVersionException extends Exception {}
 class UnknownWikiDomainException extends Exception {}
 
 class MediaWikiHostResolver {
-    // TODO: Move this mapping to a config file so that MW updates do not require code changes here.
-    // keep in sync with App\Http\Controllers\Backend\WikiDbVersionController
-    /** @var array<string, string> Map of DB version strings to MediaWiki version strings */
-    private const DB_VERSION_TO_MW_VERSION = [
-        'mw1.39-wbs1' => '139',
-        'mw1.43-wbs1' => '143',
-    ];
-
     /**
      * @throws UnknownDBVersionException
      * @throws UnknownWikiDomainException
@@ -54,8 +46,9 @@ private function getMwVersionForDomain(string $domain): string {
 
         $dbVersion = $wiki->wikiDb->version;
 
-        if (array_key_exists($dbVersion, self::DB_VERSION_TO_MW_VERSION)) {
-            return self::DB_VERSION_TO_MW_VERSION[$dbVersion];
+        $versionMap = config('mw-db-version-map');
+        if (array_key_exists($dbVersion, $versionMap)) {
+            return $versionMap[$dbVersion];
         }
         throw new UnknownDBVersionException("Unknown DB version '{$dbVersion}' for domain '{$domain}'.");
     }

config/mw-db-version-map.php

@@ -0,0 +1,9 @@
+<?php
+
+// TODO: Read from outside of this codebase so that MW updates do not require code changes here.
+$versionMap = [
+    'mw1.39-wbs1' => '139',
+    'mw1.43-wbs1' => '143',
+];
+
+return $versionMap;