add getLatestPolicies() function

Author: dati18

app/Http/Controllers/PoliciesController.php

@@ -13,10 +13,7 @@ public function getCurrentPolicies(): PoliciesCollection {
         $now = CarbonImmutable::now();
 
         // This works based on the assumption that the latest policy has the highest id given that id is AUTO_INCREMENT
-        $latestPolicyIds = Policy::where('active_from', '<', $now)
-            ->selectRaw('MAX(id) as id')
-            ->groupBy('policy_type')
-            ->pluck('id');
+        $latestPolicyIds = $this->getLatestPolicies();
 
         $currentPolicies = Policy::whereIn('id', $latestPolicyIds)->get();
 
@@ -26,19 +23,27 @@ public function getCurrentPolicies(): PoliciesCollection {
     public function getMissingPolicies(Request $request): PoliciesCollection {
         $now = CarbonImmutable::now();
 
-        $activePolicyIds = Policy::where('active_from', '<=', $now)
-            ->selectRaw('MAX(id) as id')
-            ->groupBy('policy_type')
-            ->pluck('id');
+        $activePolicyIds = $this->getLatestPolicies();
 
-        $acceptedPolicyIds = PolicyAcceptance::where('user_id', $request->user()->id)
+        $userAcceptedPolicyIds = PolicyAcceptance::where('user_id', $request->user()->id)
             ->whereIn('policy_id', $activePolicyIds)
             ->pluck('policy_id');
 
         $missingPolicies = Policy::whereIn('id', $activePolicyIds)
-            ->whereNotIn('id', $acceptedPolicyIds)
+            ->whereNotIn('id', $userAcceptedPolicyIds)
             ->get();
 
         return new PoliciesCollection($missingPolicies);
     }
+
+    private function getLatestPolicies() {
+        $now = CarbonImmutable::now();
+
+        $latestPolicyIds = Policy::where('active_from', '<', $now)
+            ->selectRaw('MAX(id) as id')
+            ->groupBy('policy_type')
+            ->pluck('id');
+
+        return $latestPolicyIds;
+    }
 }