Release 10x.18.8 (#908)

Also add a couple more validation test cases

Author: tarrow

CHANGELOG.md

@@ -1,5 +1,8 @@
 # api
 
+## 10x.18.8
+ - Fix WikiProfile Validation
+
 ## 10x.18.7
 - Include WikiProfile model and migration
 

tests/Helper/ProfileValidatorTest.php

@@ -49,6 +49,11 @@ private function invalidProfileProvider() {
                 'audience' => 'narrow',
                 'temporality' => 'other',
             ] ],
+            [ 'audience is empty string' => [
+                'purpose' => 'data_hub',
+                'audience' => '',
+                'temporality' => 'other',
+            ] ],
             [ 'audience key present when purpose not data_hub' => [
                 'purpose' => 'data_lab',
                 'audience' => 'narrow',

tests/Routes/Wiki/CreateTest.php

@@ -284,6 +284,12 @@ static public function createWikiHandlesRangeOfPostValuesProvider(): array {
                         "temporality": "permanent",
                         "purpose": "data_hub"
                       }';
+        $profileWithAudienceBlank =  self::defaultData;
+        $profileWithAudienceBlank['profile'] = '{
+                        "audience": "",
+                        "temporality": "permanent",
+                        "purpose": "data_hub"
+                    }';
         return [
             'all params present' => [self::defaultData , 200],
             'missing domain' => [$noDomain, 422],
@@ -292,7 +298,8 @@ static public function createWikiHandlesRangeOfPostValuesProvider(): array {
             'missing profile' => [$noprofile, 200],
             'profile with other' => [$profileWithOther, 200],
             'profile with other string missing' => [$profileWithOtherStringMissing, 422],
-            'profile with extraneous other' => [$profileWithExtraneousOther, 422]
+            'profile with extraneous other' => [$profileWithExtraneousOther, 422],
+            'profile with audience blank string' => [$profileWithAudienceBlank, 422]
         ];
     }