Handle Carbon 3 timestamp parsing and add regression coverage for timestamp handling

Bug: T426592

Author: dati18

app/Helper/MWTimestampHelper.php

@@ -15,8 +15,13 @@ class MWTimestampHelper {
     private const MWTimestampFormat = 'YmdHis';
 
     public static function getCarbonFromMWTimestamp(string $MWTimestamp): CarbonImmutable {
-        $carbon = CarbonImmutable::createFromFormat(self::MWTimestampFormat, $MWTimestamp);
-        if ($carbon === null) {
+        try {
+            $carbon = CarbonImmutable::createFromFormat(self::MWTimestampFormat, $MWTimestamp);
+        } catch (InvalidFormatException $exception) {
+            throw new InvalidFormatException('Unable to create Carbon object', 0, $exception);
+        }
+
+        if (!$carbon instanceof CarbonImmutable) {
             throw new InvalidFormatException('Unable to create Carbon object');
         }
 

tests/Helper/MWTimestampHelperTest.php

@@ -19,6 +19,7 @@ public function testGetCarbonFromMWTimestamp() {
 
     public function testGetCarbonFromMWTimestampWithInvalidTimestamp() {
         $this->expectException(InvalidFormatException::class);
+        $this->expectExceptionMessage('Unable to create Carbon object');
 
         $invalidMwTimestamp = 'invalid_timestamp';
         MWTimestampHelper::getCarbonFromMWTimestamp($invalidMwTimestamp);