Add rector config and fixes (#1125)

```
dc exec -it --user "$(id -u):$(id -g)" api vendor/bin/rector process
```

Bug: T426177

Author: outdooracorn

app/Console/Commands/ScheduleStatsUpdates.php

@@ -51,7 +51,7 @@ public function handle() {
 
         Bus::batch($siteStatsUpdateJobs)
             ->allowFailures()
-            ->finally(function () {
+            ->finally(function (): void {
                 dispatch(new PlatformStatsSummaryJob);
             })->dispatch();
 

app/Exceptions/Handler.php

@@ -21,7 +21,7 @@ class Handler extends ExceptionHandler {
      * Register the exception handling callbacks for the application.
      */
     public function register(): void {
-        $this->reportable(function (Throwable $e) {
+        $this->reportable(function (Throwable $e): void {
             (new ErrorReporting)->report($e);
         });
     }

app/Helper/DomainValidator.php

@@ -15,7 +15,7 @@ public function __construct(string $subDomainSuffix, array $subdomainRules) {
         $this->subdomainRules = $subdomainRules;
     }
 
-    public function getValidator($domain): \Illuminate\Validation\Validator {
+    public function getValidator($domain): \Illuminate\Contracts\Validation\Validator {
 
         $isSubdomain = WikiController::isSubDomain($domain, $this->subDomainSuffix);
 

app/Helper/ProfileValidator.php

@@ -5,7 +5,7 @@
 use Illuminate\Support\Facades\Validator;
 
 class ProfileValidator {
-    public function getValidator($profile): \Illuminate\Validation\Validator {
+    public function getValidator($profile): \Illuminate\Contracts\Validation\Validator {
 
         return Validator::make($profile, [
             'purpose' => 'in:data_hub,data_lab,tool_lab,test_drive,decide_later,other',

app/Http/Controllers/Auth/ForgotPasswordController.php

@@ -5,6 +5,7 @@
 use App\Http\Controllers\Controller;
 use Illuminate\Foundation\Auth\SendsPasswordResetEmails;
 use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
 
 class ForgotPasswordController extends Controller {
     /*
@@ -29,7 +30,7 @@ public function __construct() {
         $this->middleware('guest');
     }
 
-    protected function sendResetLinkResponse(): JsonResponse {
+    protected function sendResetLinkResponse(?Request $request = null): JsonResponse {
         return response()->json('Success', 200);
     }
 

app/Http/Controllers/Auth/RegisterController.php

@@ -32,7 +32,7 @@ public function register(Request $request) {
         $this->validator($request->all())->validate();
 
         $user = null;
-        DB::transaction(function () use (&$user, $request) {
+        DB::transaction(function () use (&$user, $request): void {
             $user = (new UserCreateJob(
                 $request->input('email'),
                 $request->input('password')

app/Http/Controllers/Auth/ResetPasswordController.php

@@ -5,6 +5,7 @@
 use App\Http\Controllers\Controller;
 use Illuminate\Foundation\Auth\ResetsPasswords;
 use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
 
 class ResetPasswordController extends Controller {
     /*
@@ -36,7 +37,7 @@ public function __construct() {
         $this->middleware('guest');
     }
 
-    protected function sendResetResponse(): JsonResponse {
+    protected function sendResetResponse(?Request $request = null): JsonResponse {
         return response()->json('Success', 200);
     }
 

app/Http/Controllers/ComplaintController.php

@@ -80,7 +80,7 @@ public function sendMessage(Request $request): JsonResponse {
     /**
      * Get a validator for an incoming complaint report page request.
      */
-    protected function validator(array $data): \Illuminate\Validation\Validator {
+    protected function validator(array $data): \Illuminate\Contracts\Validation\Validator {
         $data['name'] = $data['name'] ?? '';
         $data['email'] = $data['email'] ?? '';
 

app/Http/Controllers/ContactController.php

@@ -55,7 +55,7 @@ public function sendMessage(Request $request): JsonResponse {
     /**
      * Get a validator for an incoming contact page request.
      */
-    protected function validator(array $data): \Illuminate\Validation\Validator {
+    protected function validator(array $data): \Illuminate\Contracts\Validation\Validator {
         if (!isset($data['contactDetails'])) {
             $data['contactDetails'] = ''; // could we skip this using some feature of the validator?
         }

app/Http/Controllers/Sandbox/SandboxController.php

@@ -37,7 +37,7 @@ public function create(Request $request): Response {
         $dataSet = $request->get('dataSet');
 
         $wiki = null;
-        DB::transaction(function () use (&$wiki, $domain) {
+        DB::transaction(function () use (&$wiki, $domain): void {
             $wikiDbCondition = ['wiki_id' => null, 'version' => self::MW_VERSION];
 
             // Fail if there is not enough storage ready