Make MediaWikiHostResolver::getMwVersionForDomain() private (#1005)

Also remove its associated test.

Author: outdooracorn

app/Services/MediaWikiHostResolver.php

@@ -50,7 +50,7 @@ public function getBackendHostForDomain(string $domain): string {
         return sprintf('mediawiki-%s-app-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain));
     }
 
-    public function getMwVersionForDomain(string $domain): string {
+    private function getMwVersionForDomain(string $domain): string {
         $wiki = Wiki::where('domain', $domain)->first();
 
         if (!$wiki) {

tests/Services/MediaWikiHostResolverTest.php

@@ -13,13 +13,6 @@
 class MediaWikiHostResolverTest extends TestCase {
     use RefreshDatabase;
 
-    public function testGetMwVersionForDomain(): void {
-        $domain = (new Factory)->create()->unique()->text(30);
-        $this->createWiki($domain, 'mw1.43-wbs1');
-        $resolver = new MediaWikiHostResolver;
-        $this->assertSame('143', $resolver->getMwVersionForDomain($domain));
-    }
-
     public function testResolverRoutesToCorrectHost(): void {
         $domain = (new Factory)->create()->unique()->text(30);
         $this->createWiki($domain, 'mw1.39-wbs1');