throw if DB version isn't known

Author: tarrow

app/Services/MediaWikiHostResolver.php

@@ -3,6 +3,7 @@
 namespace App\Services;
 
 use App\Wiki;
+use Exception;
 
 class MediaWikiHostResolver {
     // TODO: Move this mapping to a config file that doesn't require updating this code when doing a MW update?
@@ -29,6 +30,11 @@ public function getMwVersionForDomain(string $domain): string {
             ->pluck('version')
             ->first();
 
-        return self::DB_VERSION_TO_MW_VERSION[$dbVersion];
+        if (array_key_exists($dbVersion, self::DB_VERSION_TO_MW_VERSION)) {
+            return self::DB_VERSION_TO_MW_VERSION[$dbVersion];
+        }
+        throw new UnknownDBVersionException;
     }
 }
+
+class UnknownDBVersionException extends Exception {}

tests/Services/MediaWikiHostResolverTest.php

@@ -3,6 +3,7 @@
 namespace Tests;
 
 use App\Services\MediaWikiHostResolver;
+use App\Services\UnknownDBVersionException;
 use App\Wiki;
 use App\WikiDb;
 use Faker\Factory;
@@ -34,6 +35,12 @@ private function createWiki(string $domain, string $version) {
     }
 
     public function testResolverThrowsIfUnableToFindHostInMap(): void {
-        $this->assertTrue(true);
+        $domain = (new Factory)->create()->unique()->text(30);
+        $this->createWiki($domain, 'mw1.39-unmapped');
+        $resolver = new MediaWikiHostResolver;
+        $this->assertThrows(
+            fn () => $resolver->getBackendHostForDomain($domain),
+            UnknownDBVersionException::class
+        );
     }
 }