fix: edit items in place when stripping prefixes, do not use regex (#708)

* fix: edit items in place when stripping prefixes, do not use regex

* docs: add changelog

Author: m90

CHANGELOG.md

@@ -1,11 +1,14 @@
 # api
 
-## 8x.28.11 - 12 December 2023
-- Batches that are done shall never be marked failed
+## 8x.29.1 - 13 December 2023
+- Try to fix memory exhaustion issue when running wbs-qs:rebuild command
 
 ## 8x.29.0 - 13 December 2023
 - Add command for rebuilding Queryservice data
 
+## 8x.28.11 - 12 December 2023
+- Batches that are done shall never be marked failed
+
 ## 8x.28.10 - 29 November 2023
 - Requeueing should not select failed batches
 

app/Console/Commands/RebuildQueryserviceData.php

@@ -92,7 +92,8 @@ private function getEntitiesForWiki (Wiki $wiki): array
             : [];
 
         $merged = array_merge($items, $properties, $lexemes);
-        return $this->stripPrefixes($merged);
+        $this->stripPrefixes($merged);
+        return $merged;
     }
 
     private function getSparqlUrl (Wiki $wiki): string
@@ -154,10 +155,11 @@ private function fetchPagesInNamespace(string $wikiDomain, int $namespace): arra
         return $titles;
     }
 
-    private static function stripPrefixes (array $items): array
+    private static function stripPrefixes (array &$items): void
     {
-        return array_map(function (string $item) {
-            return preg_replace('/^[a-zA-Z]+:/', '', $item);
-        }, $items);
+        foreach ($items as &$item) {
+            $e = explode(':', $item);
+            $item = end($e);
+        }
     }
 }