fix PlatformStatsSummaryJob

Author: deer-wmde

app/Jobs/PlatformStatsSummaryJob.php

@@ -4,6 +4,7 @@
 
 use App\Constants\MediawikiNamespace;
 use App\Helper\MWTimestampHelper;
+use App\Services\MediaWikiHostResolver;
 use App\Traits;
 use App\User;
 use App\Wiki;
@@ -39,6 +40,8 @@ class PlatformStatsSummaryJob extends Job {
 
     private $platformSummaryStatsVersion = 'v1';
 
+    private MediaWikiHostResolver $mwHostResolver;
+
     public function __construct() {
         $this->inactiveThreshold = Config::get('wbstack.platform_summary_inactive_threshold');
         $this->creationRateRanges = Config::get('wbstack.platform_summary_creation_rate_ranges');
@@ -76,6 +79,7 @@ public function prepareStats(array $allStats, $wikis): array {
         $currentTime = CarbonImmutable::now();
 
         foreach ($wikis as $wiki) {
+            $this->apiUrl = $this->mwHostResolver->getBackendHostForDomain($wiki->domain) . '/w/api.php'; // used in PageFetcher::fetchPagesInNamespace
 
             if (!is_null($wiki->deleted_at)) {
                 $deletedWikis[] = $wiki;
@@ -163,7 +167,8 @@ public function prepareStats(array $allStats, $wikis): array {
         ];
     }
 
-    public function handle(DatabaseManager $manager): void {
+    public function handle(DatabaseManager $manager, MediaWikiHostResolver $mwHostResolver): void {
+        $this->mwHostResolver = $mwHostResolver;
         $wikis = Wiki::withTrashed()->with('wikidb')->get();
 
         $conn = $manager->connection('mysql');

tests/Jobs/PlatformStatsSummaryJobTest.php

@@ -6,6 +6,7 @@
 use App\Helper\MWTimestampHelper;
 use App\Jobs\PlatformStatsSummaryJob;
 use App\Jobs\ProvisionWikiDbJob;
+use App\Services\MediaWikiHostResolver;
 use App\User;
 use App\Wiki;
 use App\WikiDb;
@@ -31,13 +32,24 @@ class PlatformStatsSummaryJobTest extends TestCase {
 
     private $db_name = 'some_cool_db_name';
 
+    private $mwBackendHost;
+
+    private $mockMwHostResolver;
+
     protected function setUp(): void {
         parent::setUp();
         for ($n = 0; $n < $this->numWikis; $n++) {
             DB::connection('mysql')->getPdo()->exec("DROP DATABASE IF EXISTS {$this->db_name}{$n};");
         }
         $this->wikis = [];
         $this->users = [];
+
+        $this->mwBackendHost = 'mediawiki.localhost';
+
+        $this->mockMwHostResolver = $this->createMock(MediaWikiHostResolver::class);
+        $this->mockMwHostResolver->method('getBackendHostForDomain')->willReturn(
+            $this->mwBackendHost
+        );
     }
 
     protected function tearDown(): void {
@@ -57,7 +69,7 @@ private function seedWikis() {
             WikiManager::factory()->create(['wiki_id' => $wiki->id, 'user_id' => $user->id]);
 
             $job = new ProvisionWikiDbJob($this->db_prefix . $n, $this->db_name . $n, null);
-            $job->handle($manager);
+            $job->handle($manager, $this->mockMwHostResolver);
 
             $wikiDb = WikiDb::whereName($this->db_name . $n)->first();
             $wikiDb->update(['wiki_id' => $wiki->id]);
@@ -80,7 +92,7 @@ public function testQueryGetsStats() {
         $job = new PlatformStatsSummaryJob;
         $job->setJob($mockJob);
 
-        $job->handle($manager);
+        $job->handle($manager, $this->mockMwHostResolver);
     }
 
     public function testGroupings() {