Fix linting for total number of entites metric (#969)

Author: AndrewKostka

app/Metrics/App/WikiMetrics.php

@@ -183,8 +183,7 @@ private function getNumberOfUsersPerActivityType(): array {
         ];
     }
 
-    private function getNumberOfEntities() : array
-    {
+    private function getNumberOfEntities(): array {
         $wikiDb = $this->wiki->wikiDb;
         $tablePage = $wikiDb->name . '.' . $wikiDb->prefix . '_page';
         $query = "SELECT
@@ -200,9 +199,10 @@ private function getNumberOfEntities() : array
         $conn = $manager->connection('mw');
         $pdo = $conn->getPdo();
         $result = $pdo->query($query)->fetchAll(PDO::FETCH_ASSOC);
-        if (count($result) === 0){
-            return [ 120 => 0, 122 => 0, 146 => 0, 640 => 0 ];
+        if (count($result) === 0) {
+            return [120 => 0, 122 => 0, 146 => 0, 640 => 0];
         }
+
         return array_column($result, 'count', 'namespace');
     }
 }

database/migrations/2025_07_30_104606_add_item_count_to_wiki_daily_merics_table.php

@@ -4,13 +4,11 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      */
-    public function up(): void
-    {
+    public function up(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->integer('item_count')->nullable()->default(null);
         });
@@ -19,8 +17,7 @@ public function up(): void
     /**
      * Reverse the migrations.
      */
-    public function down(): void
-    {
+    public function down(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->dropColumn('item_count');
         });

database/migrations/2025_07_30_104622_add_properties_count_to_wiki_daily_merics_table.php

@@ -4,13 +4,11 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      */
-    public function up(): void
-    {
+    public function up(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->integer('property_count')->nullable()->default(null);
         });
@@ -19,8 +17,7 @@ public function up(): void
     /**
      * Reverse the migrations.
      */
-    public function down(): void
-    {
+    public function down(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->dropColumn('property_count');
         });

database/migrations/2025_07_30_104657_add_lexemes_count_to_wiki_daily_merics_table.php

@@ -4,13 +4,11 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      */
-    public function up(): void
-    {
+    public function up(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->integer('lexeme_count')->nullable()->default(null);
         });
@@ -19,8 +17,7 @@ public function up(): void
     /**
      * Reverse the migrations.
      */
-    public function down(): void
-    {
+    public function down(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->dropColumn('lexeme_count');
         });

database/migrations/2025_07_30_104719_add_entity_schemas_count_to_wiki_daily_merics_table.php

@@ -4,13 +4,11 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      */
-    public function up(): void
-    {
+    public function up(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->integer('entity_schema_count')->nullable()->default(null);
         });
@@ -19,8 +17,7 @@ public function up(): void
     /**
      * Reverse the migrations.
      */
-    public function down(): void
-    {
+    public function down(): void {
         Schema::table('wiki_daily_metrics', function (Blueprint $table) {
             $table->dropColumn('entity_schema_count');
         });

tests/Metrics/WikiMetricsTest.php

@@ -168,10 +168,9 @@ public function testSaveNullForFailedRequestOfTriplesCount() {
         ]);
     }
 
-    public function testSavesEntityCountsCorrectly()
-    {
+    public function testSavesEntityCountsCorrectly() {
         $wiki = Wiki::factory()->create([
-            'domain' => 'entitycounttest.wikibase.cloud'
+            'domain' => 'entitycounttest.wikibase.cloud',
         ]);
 
         $wikiDb = WikiDb::first();
@@ -200,7 +199,7 @@ public function testSavesEntityCountsCorrectly()
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 1,
-                'page_len' => 2
+                'page_len' => 2,
             ], // item
             [
                 'page_namespace' => 120,
@@ -209,7 +208,7 @@ public function testSavesEntityCountsCorrectly()
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 0,
-                'page_len' => 2
+                'page_len' => 2,
             ], // item
             [
                 'page_namespace' => 122,
@@ -218,16 +217,15 @@ public function testSavesEntityCountsCorrectly()
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 1,
-                'page_len' => 2]
-            , // property
+                'page_len' => 2], // property
             [
                 'page_namespace' => 640,
                 'page_is_redirect' => 0,
                 'page_title' => 'bar',
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 1,
-                'page_len' => 2
+                'page_len' => 2,
             ], // entity schema
             [
                 'page_namespace' => 146,
@@ -236,7 +234,7 @@ public function testSavesEntityCountsCorrectly()
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 1,
-                'page_len' => 2
+                'page_len' => 2,
             ], // lexeme
             [
                 'page_namespace' => 640,
@@ -245,20 +243,20 @@ public function testSavesEntityCountsCorrectly()
                 'page_random' => 0,
                 'page_touched' => random_bytes(10),
                 'page_latest' => 1,
-                'page_len' => 2
+                'page_len' => 2,
             ], // entity schema
         ]);
         WikiDailyMetrics::create([
             'id' => $wiki->id . '_' . now()->subDay()->toDateString(),
             'wiki_id' => $wiki->id,
             'date' => now()->subDay()->toDateString(),
             'pages' => 6,
-            'is_deleted' => 0
+            'is_deleted' => 0,
         ]);
 
-        (new WikiMetrics())->saveMetrics($wiki);
+        (new WikiMetrics)->saveMetrics($wiki);
 
-        //clean up after the test
+        // clean up after the test
         $wiki->forceDelete();
         Schema::dropIfExists($tablePage);
 
@@ -267,7 +265,7 @@ public function testSavesEntityCountsCorrectly()
             'item_count' => 2,
             'property_count' => 1,
             'lexeme_count' => 1,
-            'entity_schema_count' => 1 // the redirect should be ignored
+            'entity_schema_count' => 1, // the redirect should be ignored
         ]);
     }
 }