Skip to content

Fix version mapping in MediaWikiHostResolver #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outdooracorn merged 1 commit into from
Nov 17, 2025
Merged

Fix version mapping in MediaWikiHostResolver #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/Services/MediaWikiHostResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ class UnknownWikiDomainException extends Exception {}

class MediaWikiHostResolver {
// TODO: Move this mapping to a config file so that MW updates do not require code changes here.
/** @var array<string, string> Map of DB version strings to MediaWiki backend version strings */
/** @var array<string, string> Map of DB version strings to MediaWiki version strings */
private const DB_VERSION_TO_MW_VERSION = [
'mw1.39-wbs1' => '139-app',
'mw1.43-wbs1' => '143-app',
'mw1.39-wbs1' => '139',
'mw1.43-wbs1' => '143',
];

// https://phabricator.wikimedia.org/T409530
Expand All @@ -31,7 +31,7 @@ class MediaWikiHostResolver {

public function getBackendHostForDomain(string $domain): string {
// TODO: Move 'backend.default.svc.cluster.local' to an env variable (e.g. PLATFORM_MW_BACKEND_HOST_SUFFIX) for flexibility.
return sprintf('mediawiki-%s-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain));
return sprintf('mediawiki-%s-app-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain));
}

public function getMwVersionForDomain(string $domain): string {
Expand Down
7 changes: 7 additions & 0 deletions tests/Services/MediaWikiHostResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
class MediaWikiHostResolverTest extends TestCase {
use RefreshDatabase;

public function testGetMwVersionForDomain(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.43-wbs1');
$resolver = new MediaWikiHostResolver;
$this->assertSame('143', $resolver->getMwVersionForDomain($domain));
}

public function testResolverRoutesToCorrectHost(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.39-wbs1');
Expand Down
Loading