From 9e848900f2a2cb26b8153c70f1f8e6de05418a33 Mon Sep 17 00:00:00 2001
From: Ollie <oliver.hyde@wikimedia.de>
Date: Thu, 20 Nov 2025 14:08:27 +0000
Subject: [PATCH] Make MediaWikiHostResolver::getMwVersionForDomain() private

Also remove its associated test.
---
 app/Services/MediaWikiHostResolver.php       | 2 +-
 tests/Services/MediaWikiHostResolverTest.php | 7 -------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/app/Services/MediaWikiHostResolver.php b/app/Services/MediaWikiHostResolver.php
index d4cd4f47d..9ccbde2d0 100644
--- a/app/Services/MediaWikiHostResolver.php
+++ b/app/Services/MediaWikiHostResolver.php
@@ -50,7 +50,7 @@ public function getBackendHostForDomain(string $domain): string {
         return sprintf('mediawiki-%s-app-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain));
     }
 
-    public function getMwVersionForDomain(string $domain): string {
+    private function getMwVersionForDomain(string $domain): string {
         $wiki = Wiki::where('domain', $domain)->first();
 
         if (!$wiki) {
diff --git a/tests/Services/MediaWikiHostResolverTest.php b/tests/Services/MediaWikiHostResolverTest.php
index 379b6e190..d3dfe0023 100644
--- a/tests/Services/MediaWikiHostResolverTest.php
+++ b/tests/Services/MediaWikiHostResolverTest.php
@@ -13,13 +13,6 @@
 class MediaWikiHostResolverTest extends TestCase {
     use RefreshDatabase;
 
-    public function testGetMwVersionForDomain(): void {
-        $domain = (new Factory)->create()->unique()->text(30);
-        $this->createWiki($domain, 'mw1.43-wbs1');
-        $resolver = new MediaWikiHostResolver;
-        $this->assertSame('143', $resolver->getMwVersionForDomain($domain));
-    }
-
     public function testResolverRoutesToCorrectHost(): void {
         $domain = (new Factory)->create()->unique()->text(30);
         $this->createWiki($domain, 'mw1.39-wbs1');