Skip to content

Make MediaWikiHostResolver::getMwVersionForDomain() private #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outdooracorn merged 1 commit into from
Nov 20, 2025
Merged

Make MediaWikiHostResolver::getMwVersionForDomain() private #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Services/MediaWikiHostResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function getBackendHostForDomain(string $domain): string {
return sprintf('mediawiki-%s-app-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain));
}

public function getMwVersionForDomain(string $domain): string {
private function getMwVersionForDomain(string $domain): string {
$wiki = Wiki::where('domain', $domain)->first();

if (!$wiki) {
Expand Down
7 changes: 0 additions & 7 deletions tests/Services/MediaWikiHostResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@
class MediaWikiHostResolverTest extends TestCase {
use RefreshDatabase;

public function testGetMwVersionForDomain(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.43-wbs1');
$resolver = new MediaWikiHostResolver;
$this->assertSame('143', $resolver->getMwVersionForDomain($domain));
}

public function testResolverRoutesToCorrectHost(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.39-wbs1');
Expand Down
Loading