Skip to content

chore: streamline k8s job TTLs #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outdooracorn merged 4 commits into from
Dec 8, 2025
Merged

chore: streamline k8s job TTLs #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ca7a1d
streamline job ttl to 1 week
deer-wmde Nov 21, 2025
9bb996e
Update WikiEntityImportJob.php
deer-wmde Nov 21, 2025
cb09961
add calculations
deer-wmde Dec 4, 2025
9339e2a
Add comment to app/Jobs/ProcessMediaWikiJobsJob.php
outdooracorn Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Jobs/ProcessMediaWikiJobsJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public function handle(Client $kubernetesClient, MediaWikiHostResolver $resolver
],
],
'spec' => [
// This is set to immediately expire since the name of the job is used as the lock to prevent creating duplicates of this Kubernetes Job for any given Wiki.
'ttlSecondsAfterFinished' => 0,
'template' => [
'metadata' => [
Expand Down
2 changes: 1 addition & 1 deletion app/Jobs/SpawnQueryserviceUpdaterJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function handle(Client $kubernetesClient): void {
],
],
'spec' => [
'ttlSecondsAfterFinished' => 14 * 24 * 60 * 60, // 2 weeks
Comment thread
deer-wmde marked this conversation as resolved.
'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week

@tarrow tarrow Dec 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue moving from 2 weeks to one week here. There is a small chance that this means we'll have all been away and are unable to inspect something here but that's probably the case with any length of time we pick

'template' => [
'metadata' => [
'name' => 'run-qs-updater',
Expand Down
2 changes: 1 addition & 1 deletion app/Jobs/WikiEntityImportJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ private function constructSpec(): array {
],
],
'spec' => [
'ttlSecondsAfterFinished' => 0,
'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week

@tarrow tarrow Dec 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably does make sense to keep these around for a while

'backoffLimit' => 0,
'template' => [
'metadata' => [
Expand Down
Loading