Update test to pass expected parameter#1016
Merged
Merged
Conversation
tarrow
reviewed
Nov 27, 2025
| $this->putJson($this->route, [ | ||
| 'domain' => $wiki->domain, | ||
| 'readOnly' => false, | ||
| 'readOnly' => 0, |
Contributor
There was a problem hiding this comment.
I wonder why this worked before? Simply because it was false not "false"?
tarrow
approved these changes
Nov 27, 2025
deer-wmde
pushed a commit
that referenced
this pull request
Dec 15, 2025
Follow up refactoring for #1009. I believe it is important for tests to reflect exactly how we expect things to work. As we updated the value of `readOnly` on the task description, I thought it would be good to update the test too. Bug: T410395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up refactoring for #1009. I believe it is important for tests to reflect exactly how we expect things to work. As we updated the value of
readOnlyon the task description, I thought it would be good to update the test too.Bug: T410395