Expand usage of LimitWikiAccess middleware#937
Merged
Conversation
AndrewKostka
changed the title
tarrow
reviewed
May 27, 2025
tarrow
reviewed
May 27, 2025
AndrewKostka
force-pushed
the
refactor-LimitWikiAccess
branch
from
f4cb4ea to
f1c4b8b
Compare
* Remove now unused imports * Add indents to method chain
outdooracorn
approved these changes
Jun 24, 2025
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
LGTM! Added a commit to fix some minor code quality issues I saw during review. I hope that's okay.
deer-wmde
pushed a commit
that referenced
this pull request
Dec 15, 2025
* Refactor LimitWikiAccess middleware * Add missing test cases prior to refactoring * Refactor routes to use LimitWikiAccess middleware * Rename LimitWikiAccessText to LimitWikiAccessTest * Use RefreshDatabase for LimitWikiAccessTest * Return 404 for non-existent wikis * Minor code cleanup during review * Remove now unused imports * Add indents to method chain --------- Co-authored-by: Ollie <oliver.hyde@wikimedia.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T394986