From dbe05d541f7a5bd1a451c2deccb6e0502e6f7301 Mon Sep 17 00:00:00 2001
From: Andrew Kostka <andrew.kostka@wikimedia.de>
Date: Thu, 22 May 2025 14:10:02 +0000
Subject: [PATCH] Remove unused route for listing wiki managers

---
 .../Controllers/WikiManagersController.php    | 34 -------------------
 routes/api.php                                |  2 --
 tests/Routes/Wiki/Managers/ListTest.php       | 13 -------
 3 files changed, 49 deletions(-)
 delete mode 100644 app/Http/Controllers/WikiManagersController.php
 delete mode 100644 tests/Routes/Wiki/Managers/ListTest.php

diff --git a/app/Http/Controllers/WikiManagersController.php b/app/Http/Controllers/WikiManagersController.php
deleted file mode 100644
index f3468413e..000000000
--- a/app/Http/Controllers/WikiManagersController.php
+++ /dev/null
@@ -1,34 +0,0 @@
-<?php
-
-namespace App\Http\Controllers;
-
-use App\WikiManager;
-use Illuminate\Http\Request;
-
-class WikiManagersController extends Controller
-{
-    public function getManagersOfWiki(Request $request): \Illuminate\Http\Response
-    {
-        $user = $request->user();
-
-        $wikiId = $request->input('wiki');
-
-        // TODO require user to be manager of the current wiki
-        $test = WikiManager::where('user_id', $user->id)
-      ->where('wiki_id', $wikiId)
-      ->first();
-        if (! $test) {
-            abort(403);
-        }
-
-        $result = WikiManager::where('wiki_id', $wikiId)
-      ->leftJoin('users', 'user_id', '=', 'users.id')
-      ->select('users.*')
-      ->get();
-
-        $res['success'] = true;
-        $res['data'] = $result;
-
-        return response($res);
-    }
-}
diff --git a/routes/api.php b/routes/api.php
index f7c272258..015ffd585 100644
--- a/routes/api.php
+++ b/routes/api.php
@@ -43,8 +43,6 @@
             $router->get('details', ['uses' => 'WikiController@getWikiDetailsForIdForOwner']);
             $router->post('logo/update', ['uses' => 'WikiLogoController@update']);
             $router->post('setting/{setting}/update', ['uses' => 'WikiSettingController@update']);
-            // TODO should wiki managers really be here?
-            $router->post('managers/list', ['uses' => 'WikiManagersController@getManagersOfWiki']);
             $router->get('entityImport', ['middleware' => 'limit_wiki_access', 'uses' => 'WikiEntityImportController@get']);
             $router->post('entityImport', ['middleware' => 'limit_wiki_access', 'uses' => 'WikiEntityImportController@create']);
             $router->post('profile', ['middleware' => 'limit_wiki_access', 'uses' => 'WikiProfileController@create']);
diff --git a/tests/Routes/Wiki/Managers/ListTest.php b/tests/Routes/Wiki/Managers/ListTest.php
deleted file mode 100644
index 119c0d1c8..000000000
--- a/tests/Routes/Wiki/Managers/ListTest.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-
-namespace Tests\Routes\Wiki\Managers;
-
-use Tests\Routes\Traits\OptionsRequestAllowed;
-use Tests\TestCase;
-
-class ListTest extends TestCase
-{
-    protected $route = 'wiki/managers/list';
-
-    use OptionsRequestAllowed;
-}