wikiMetrics: fix zero count occassions#972
Merged
Merged
Conversation
rosalieper
approved these changes
Sep 5, 2025
Contributor
rosalieper
left a comment
rosalieper
left a comment
There was a problem hiding this comment.
looks good to me. Thank you Dena!
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
* add dataProvider for test * add the fix * lintin * more linting * even more linting * linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen[1] an error in the current WikiMetrics code in case there are zero entries for a type of entity metrics, but not zero in total: https://github.com/wbstack/api/blob/main/app/Metrics/App/WikiMetrics.php#L202
This PR attempts to provide a fix and extends the test case for this type of error.
[1] https://console.cloud.google.com/errors/detail/CIiQvbv5l_3pHA;locations=global;time=P30D?project=wikibase-cloud&utm_source=error-reporting-notification&utm_medium=email&utm_content=new-error