Introduce MediaWikiHostResolver#989
Merged
Merged
Conversation
Co-authored-by: Ollie <oliver.hyde@wikimedia.de> Bug: T409085 Bug: T408624
tarrow
force-pushed
the
MediaWikiHostResolver
branch
from
667287c to
cf6f384
Compare
dati18
requested changes
Nov 5, 2025
Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
dati18
reviewed
Nov 5, 2025
Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
dati18
approved these changes
Nov 5, 2025
Contributor
|
LGTM now! |
deer-wmde
pushed a commit
that referenced
this pull request
Dec 15, 2025
* Introduce MediaWikiHostResolver Co-authored-by: Ollie <oliver.hyde@wikimedia.de> Bug: T409085 Bug: T408624 * run pint * revert Wiki.php changes * throw if DB version isn't known * Update app/Services/MediaWikiHostResolver.php Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de> * Update app/Services/MediaWikiHostResolver.php Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de> * use relations and accessors * fix indent * Update app/Services/MediaWikiHostResolver.php Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de> * Update app/Services/MediaWikiHostResolver.php Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de> * move exception above class --------- Co-authored-by: Ollie <oliver.hyde@wikimedia.de> Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new Service that currently takes no configuration following the
Laravel service container pattern[1]. In the future we probably want to make this configurable
and in production pass in this configuration with a ConfigMap.
The intention is to use this for resolution of the correct backend host for MediaWiki
depending on the DB schema for that Wiki.
The idea was extracted from the POC at #987
[1] https://laravel.com/docs/10.x/container
Bug: T409085
Bug: T408624