Fix calls to deprecated version of PHPUnit providers#990
Merged
Conversation
All PHPUnit Providers now need to be static and public[1]. This commit fixes the references to these in what I believe was the simplest way possible. In ElasticSearchIndexInitTest this meant it was necessary to move some mocking out of the provider and into the test directly. I investigated creating mocks statically; I discovered `mock()` which creates a Mockery mock but I decided that making the decision to move to a different mock library wasn't what I wanted to do here. I just wanted my tests to run without deprecation warnings. [1] sebastianbergmann/phpunit@9caafe2
dati18
approved these changes
Nov 5, 2025
deer-wmde
pushed a commit
that referenced
this pull request
Dec 15, 2025
All PHPUnit Providers now need to be static and public[1]. This commit fixes the references to these in what I believe was the simplest way possible. In ElasticSearchIndexInitTest this meant it was necessary to move some mocking out of the provider and into the test directly. I investigated creating mocks statically; I discovered `mock()` which creates a Mockery mock but I decided that making the decision to move to a different mock library wasn't what I wanted to do here. I just wanted my tests to run without deprecation warnings. [1] sebastianbergmann/phpunit@9caafe2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PHPUnit Providers now need to be static and public[1].
This commit fixes the references to these in what I believe was the simplest way possible. In ElasticSearchIndexInitTest this meant it was necessary to move some mocking out of the provider and into the test directly.
I investigated creating mocks statically; I discovered
mock()which creates a Mockery mock but I decided that making the decision to move to a different mock library wasn't what I wanted to do here. I just wanted my tests to run without deprecation warnings.[1] sebastianbergmann/phpunit@9caafe2