fix: more error handling for MediaWikiHostResolver#994
Merged
Conversation
Contributor
Author
|
on second thought its probably not necessary, fallback could be provided via helm chart value on client side. |
deer-wmde
added a commit
that referenced
this pull request
Nov 7, 2025
deer-wmde
added a commit
that referenced
this pull request
Nov 7, 2025
deer-wmde
changed the title
dati18
approved these changes
Nov 11, 2025
deer-wmde
added a commit
that referenced
this pull request
Nov 11, 2025
deer-wmde
added a commit
that referenced
this pull request
Nov 14, 2025
* remove obsolete apiUrl assignment * refactor MediawikiInit Job * refactor MediawikiSandboxLoadData * refactor CirrusSearchJob * refactor SiteStatsUpdateJob * Revert "remove obsolete apiUrl assignment" This reverts commit f8635db. * refactor PageFetcher and its uses * refactor PollForMediaWikiJobsJob * refactor WikiEntityImportJob * refactor UpdateWikiSiteStatsJob * fix copypasta * add Wiki::getBackendHost * use Wiki::getBackendHost in UpdateWikiSiteStatsJob * refactor CirrusSearchJob * update SiteStatsUpdateJob * attempt to fix wikiEntityImportJob * remove Wiki::getBackendHost() * typo * add function keyword * add ; * remove ; * fix MediawikiInitTest * CirrusSearchJob fix resolver access * wikiEntityImportJob: fix mwHostResolver access in static method * refactor class creation * add mock resoler to ElasticSearchIndexInitTest * mock resolver in ForceSearchIndexTest * mock resolver in QueueSearchIndexBatchesTest * fix PollForMediaWikiJobsJob * fix SiteStatsUpdateJobTest * streamline tests * streamline naming * fix PageFetcher * cleanup * fix UpdateWikiSiteStatsJob * fix WikiEntityImportJob * undo refactoring * fix PlatformStatsSummaryJob * fix RebuildQueryserviceData * run pint fix * remove changes from #994 * linting * clean up usages of PLATFORM_MW_BACKEND_HOST in tests * fix rebase * fix rebase part 2
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
* remove obsolete apiUrl assignment * refactor MediawikiInit Job * refactor MediawikiSandboxLoadData * refactor CirrusSearchJob * refactor SiteStatsUpdateJob * Revert "remove obsolete apiUrl assignment" This reverts commit f8635db. * refactor PageFetcher and its uses * refactor PollForMediaWikiJobsJob * refactor WikiEntityImportJob * refactor UpdateWikiSiteStatsJob * fix copypasta * add Wiki::getBackendHost * use Wiki::getBackendHost in UpdateWikiSiteStatsJob * refactor CirrusSearchJob * update SiteStatsUpdateJob * attempt to fix wikiEntityImportJob * remove Wiki::getBackendHost() * typo * add function keyword * add ; * remove ; * fix MediawikiInitTest * CirrusSearchJob fix resolver access * wikiEntityImportJob: fix mwHostResolver access in static method * refactor class creation * add mock resoler to ElasticSearchIndexInitTest * mock resolver in ForceSearchIndexTest * mock resolver in QueueSearchIndexBatchesTest * fix PollForMediaWikiJobsJob * fix SiteStatsUpdateJobTest * streamline tests * streamline naming * fix PageFetcher * cleanup * fix UpdateWikiSiteStatsJob * fix WikiEntityImportJob * undo refactoring * fix PlatformStatsSummaryJob * fix RebuildQueryserviceData * run pint fix * remove changes from #994 * linting * clean up usages of PLATFORM_MW_BACKEND_HOST in tests * fix rebase * fix rebase part 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #989
Bug: T409085