Update to MediaWiki 1.38 (#321)

* First Attempt at 1.38 Image

* fix pacman.yaml linting

* Run sync again

* Update composer

* replace patch for Wikibase unit rebuilding code

* Include files from patch

* fix references to OAuth classes

* Remove $wgShellLocale from our LocalSettings.php

Bug: T331855

* Switch from using $IP to $wgBaseDirectory

Bug: T331855

* Run sync_dist-persist.sh

---------

Co-authored-by: Andrew Kostka <andrew.kostka@wikimedia.de>
Co-authored-by: Andrew Kostka <3535245+AndrewKostka@users.noreply.github.com>

Author: tarrow

dist-persist/composer.lock

@@ -10,12 +10,12 @@ public function mustBePosted() {return true;}
     public function isWriteMode() {return true;}
     public function isInternal() {return true;}
     public function execute() {
-        global $IP;
+        global $wgBaseDirectory;
 
         @set_time_limit( 60*5 ); // 5 mins maybe D:
 		@ini_set( 'memory_limit', '-1' ); // also try to disable the memory limit? Is this even a good idea?
 		
-		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $IP . '/extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php';
+		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $wgBaseDirectory . '/extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php';
 		exec($cmd, $out, $return);
 
 		// Return appropriate result

dist-persist/wbstack/src/Internal/ApiWbStackElasticSearchInit.php

@@ -10,7 +10,7 @@ public function mustBePosted() {return true;}
     public function isWriteMode() {return true;}
     public function isInternal() {return true;}
     public function execute() {
-        global $IP;
+        global $wgBaseDirectory;
 
         @set_time_limit( 60*5 ); // 5 mins maybe D:
 		@ini_set( 'memory_limit', '-1' ); // also try to disable the memory limit? Is this even a good idea?
@@ -19,7 +19,7 @@ public function execute() {
         $toId = $this->getParameter('toId');
 
         $parameters = "--skipLinks 1 --indexOnSkip 1 --fromId " . escapeshellarg( $fromId ) . " --toId " . escapeshellarg( $toId );
-		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $IP . '/extensions/CirrusSearch/maintenance/ForceSearchIndex.php ' . $parameters;
+		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $wgBaseDirectory . '/extensions/CirrusSearch/maintenance/ForceSearchIndex.php ' . $parameters;
 		exec($cmd, $out, $return);
 
 		// Return appropriate result

dist-persist/wbstack/src/Internal/ApiWbStackForceSearchIndex.php

@@ -10,13 +10,13 @@ public function mustBePosted() {return true;}
     public function isWriteMode() {return true;}
     public function isInternal() {return true;}
     public function execute() {
-        global $IP;
+        global $wgBaseDirectory;
 
         @set_time_limit( 60*5 ); // 5 mins maybe D:
 		@ini_set( 'memory_limit', '-1' ); // also try to disable the memory limit? Is this even a good idea?
 		
         $parameters = "--skipLinks --indexOnSkip --buildChunks 10000";
-		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $IP . '/extensions/CirrusSearch/maintenance/ForceSearchIndex.php ' . $parameters . ' 2>&1';
+		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $wgBaseDirectory . '/extensions/CirrusSearch/maintenance/ForceSearchIndex.php ' . $parameters . ' 2>&1';
 		exec($cmd, $out, $return);
 
 		// Return appropriate result

dist-persist/wbstack/src/Internal/ApiWbStackQueueSearchIndexBatches.php

@@ -10,12 +10,12 @@ public function mustBePosted() {return true;}
     public function isWriteMode() {return true;}
     public function isInternal() {return true;}
     public function execute() {
-        global $IP;
+        global $wgBaseDirectory;
 
         @set_time_limit( 60*5 ); // 5 mins maybe D:
 		@ini_set( 'memory_limit', '-1' ); // also try to disable the memory limit? Is this even a good idea?
 		
-		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $IP . '/maintenance/initSiteStats.php --update --active';
+		$cmd = 'WBS_DOMAIN=' . $GLOBALS[WBSTACK_INFO_GLOBAL]->requestDomain . ' php ' . $wgBaseDirectory . '/maintenance/initSiteStats.php --update --active';
 		exec($cmd, $out, $return);
 
 		// Return appropriate result

dist-persist/wbstack/src/Internal/ApiWbStackSiteStatsUpdate.php

@@ -79,8 +79,8 @@ public static function createOauthConsumer($consumerName, $version, $grants, $ca
         $context = \RequestContext::getMain();
         $context->setUser( self::getUser() );
 
-        $dbw = \MediaWiki\Extensions\OAuth\Backend\Utils::getCentralDB( DB_MASTER );
-        $control = new \MediaWiki\Extensions\OAuth\Control\ConsumerSubmitControl( $context, $data, $dbw );
+        $dbw = \MediaWiki\Extension\OAuth\Backend\Utils::getCentralDB( DB_MASTER );
+        $control = new \MediaWiki\Extension\OAuth\Control\ConsumerSubmitControl( $context, $data, $dbw );
         $status = $control->submit();
 
         if ( !$status->isGood() ) {
@@ -96,7 +96,7 @@ public static function createOauthConsumer($consumerName, $version, $grants, $ca
             'reason'       => 'Approved by platform',
             'changeToken'  => $cmr->getChangeToken( $context ),
         ];
-        $control = new \MediaWiki\Extensions\OAuth\Control\ConsumerSubmitControl( $context, $data, $dbw );
+        $control = new \MediaWiki\Extension\OAuth\Control\ConsumerSubmitControl( $context, $data, $dbw );
         $approveStatus = $control->submit();
 
         if ( !$approveStatus->isGood() ) {
@@ -116,11 +116,11 @@ public static function getOAuthConsumer($consumerName, $version) {
             return false;
         }
 
-        $db = \MediaWiki\Extensions\OAuth\Backend\Utils::getCentralDB( DB_REPLICA );
+        $db = \MediaWiki\Extension\OAuth\Backend\Utils::getCentralDB( DB_REPLICA );
 
         // $c is a Consumer
         // https://github.com/wikimedia/mediawiki-extensions-OAuth/blob/master/src/Backend/Consumer.php
-        $c = \MediaWiki\Extensions\OAuth\Backend\Consumer::newFromNameVersionUser(
+        $c = \MediaWiki\Extension\OAuth\Backend\Consumer::newFromNameVersionUser(
             $db,
             $consumerName,
             $version,
@@ -134,7 +134,7 @@ public static function getOAuthConsumer($consumerName, $version) {
         return [
             'agent' => $c->getName(),
             'consumerKey' => $c->getConsumerKey(),
-            'consumerSecret' => \MediaWiki\Extensions\OAuth\Backend\Utils::hmacDBSecret( $c->getSecretKey() ),
+            'consumerSecret' => \MediaWiki\Extension\OAuth\Backend\Utils::hmacDBSecret( $c->getSecretKey() ),
         ];
     }
 }

dist-persist/wbstack/src/Internal/WbStackPlatformReservedUser.php

@@ -252,18 +252,10 @@
 // TODO sort out directories and stuff...?
 // $wgCacheDirectory is needed at least for the l10n rebuild
 $wgCacheDirectory = '/tmp/mw-cache';
-//$wgUploadDirectory = "{$IP}/images/docker/{$dockerDb}";
+//$wgUploadDirectory = "{$wgBaseDirectory}/images/docker/{$dockerDb}";
 //$wgUploadPath = "{$wgScriptPath}/images/docker/{$dockerDb}";
 //$wgTmpDirectory = "{$wgUploadDirectory}/tmp";
 
-## Locale
-/**
- * The docker image only has C.UTF-8 currently.
- * This is the default for https://www.mediawiki.org/wiki/Manual:$wgShellLocale for core as of 1.30
- * But explicitly set it here as it is all the image has!
- */
-$wgShellLocale = "C.UTF-8";
-
 #######################################
 ## ---   Default Permissions     --- ##
 #######################################
@@ -490,10 +482,10 @@ function onPersonalUrlsConfirmAccount( array &$personal_urls, Title $title, Skin
 #######################################
 ## ---          Wikibase         --- ##
 #######################################
-wfLoadExtension( 'WikibaseRepository', "$IP/extensions/Wikibase/extension-repo.json" );
-require_once "$IP/extensions/Wikibase/repo/ExampleSettings.php";
-wfLoadExtension( 'WikibaseClient', "$IP/extensions/Wikibase/extension-client.json" );
-require_once "$IP/extensions/Wikibase/client/ExampleSettings.php";
+wfLoadExtension( 'WikibaseRepository', "$wgBaseDirectory/extensions/Wikibase/extension-repo.json" );
+require_once "$wgBaseDirectory/extensions/Wikibase/repo/ExampleSettings.php";
+wfLoadExtension( 'WikibaseClient', "$wgBaseDirectory/extensions/Wikibase/extension-client.json" );
+require_once "$wgBaseDirectory/extensions/Wikibase/client/ExampleSettings.php";
 
 $wwWikibaseStringLengthString = $wikiInfo->getSetting('wwWikibaseStringLengthMonolingualText');
 if($wwWikibaseStringLengthString) {

dist-persist/wbstack/src/Settings/LocalSettings.php

@@ -1,5 +1,5 @@
 {{int:version-credits-summary}} <!--
-MediaWiki 1.37 is a collaborative project released under the
+MediaWiki 1.38 is a collaborative project released under the
 GNU General Public License v2. We would like to recognize the
 following names for their contribution to the product.
 
@@ -20,6 +20,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * abhinand
 * Abhishek Das
 * Abián
+* Abijeet Patro
 * Acamicamacaraca
 * Ad Huikeshoven
 * Adam Miller
@@ -55,6 +56,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Alexander Sigachov
 * Alexander Vorwerk
 * Alexandre Emsenhuber
+* Alexandros Kosiaris
 * Alexia E. Smith
 * AlQaholic007
 * Amalthea
@@ -122,6 +124,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Bene
 * Benny Situ
 * Bergi
+* Bernard Wang
 * Bertrand Grondin
 * Bill Pirkle
 * Bill Traynor
@@ -161,6 +164,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Chad Horohoe
 * Charles Melbye
 * Chiefwei
+* Chris Danis
 * Chris McMahon
 * Chris Seaton
 * Chris Steipp
@@ -230,13 +234,17 @@ The following list can be found parsed under Special:Version/Credits -->
 * Devi Krishnan
 * didicodes
 * Diederik van Liere
+* diesel
 * divadsn
 * diwanshu885
+* Dmitriy Sky
 * Domas Mituzas
 * Douglas Gardner
 * Dov Alperin
 * DPStokesNZ
 * dr0ptp4kt
+* drynok
+* dylsss
 * Ebrahim Byagowi
 * Ed Sanders
 * Ed Schouten
@@ -342,6 +350,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Inez Korczyński
 * IoannisKydonis
 * Ireas
+* Isabelle Hurbain-Palatin
 * isarra
 * Itamar Givon
 * Ivan Lanin
@@ -406,6 +415,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Jonathan
 * Jonathan Wiltshire
 * Jools Wills
+* joseph emmanuel kayode (iemarjay)
 * jsahleen
 * Juan Osorio
 * Julian Ostrow
@@ -431,6 +441,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Kim Hyun-Joon
 * kipod
 * kishanio
+* KleinMuci
 * konarak
 * Kosta Harlan
 * krishna keshav
@@ -532,6 +543,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Max Semenik
 * Max Sikström
 * mayankmadan
+* mbsantos
 * mech
 * Mehmet Mert Yıldıran
 * Melos
@@ -625,6 +637,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * opatel99
 * Oren Held
 * Ori Livneh
+* osamaahmed17
 * oskar.jauch@gmail.com
 * Ostrzyciel
 * Ottomata
@@ -742,6 +755,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Sam Smith
 * Sam Wilson
 * SamanthaNguyen
+* Samuel Guebo
 * Samuel Hilson
 * Santhosh Thottingal
 * saptaks
@@ -772,11 +786,13 @@ The following list can be found parsed under Special:Version/Credits -->
 * shirayuki
 * Shreyas Minocha
 * shubham656
+* Siddharth VP
 * Sidhant Gupta
 * Siebrand Mazeland
 * Simeon Dahl
 * Simon Legner
 * Simon Walker
+* Simone This Dot
 * Smriti Singh
 * Sohom Datta
 * Solitarius
@@ -787,6 +803,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Srđan
 * Srikanth Lakshmanan
 * ST47
+* stang
 * Stanislav Malyshev
 * Stefano Codari
 * Steinsplitter
@@ -843,6 +860,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * tjlsangria
 * Tjones
 * TK-999
+* Tks4Fish
 * Tobi_406
 * Tobias Gritschacher
 * Tom Arrow
@@ -855,6 +873,7 @@ The following list can be found parsed under Special:Version/Credits -->
 * Toni Hermoso Pulido
 * Tony Thomas
 * Tpt
+* Tranve
 * Trevor Parscal
 * Trey Jones
 * tsepothoabala
@@ -895,9 +914,12 @@ The following list can be found parsed under Special:Version/Credits -->
 * wikitrent
 * Wil Mahan
 * William Demchick
+* Winston Sung
 * withoutaname
 * WMDE-Fisch
 * X!
+* xiplus
+* xover
 * XP1
 * Yaron Koren
 * Yaroslav Melnychuk