From 7bacff2836c6b3af358b43d19baa7c1f655a6d3a Mon Sep 17 00:00:00 2001
From: Thomas Arrow <thomas.arrow@wikimedia.de>
Date: Tue, 21 Oct 2025 09:25:15 +0100
Subject: [PATCH] Replace call to removed MWHttpRequest::factory

Since 1.34 MWHttpRequest::factory has been deprecated and
it was removed in 1.41. This patch replaces it with what I
believe is the obvious successor: HttpRequestFactory

This follows the recommended pattern from the mediawiki.org
docs[1] of creating the factory from MediaWikiServices and then
calls it with the options as before.

[1] https://www.mediawiki.org/wiki/Manual:HttpRequestFactory.php

Bug: T407480
---
 dist-persist/wbstack/src/Settings/Hooks.php | 5 ++++-
 dist/wbstack/src/Settings/Hooks.php         | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/dist-persist/wbstack/src/Settings/Hooks.php b/dist-persist/wbstack/src/Settings/Hooks.php
index 804eed34a..654e7cb24 100644
--- a/dist-persist/wbstack/src/Settings/Hooks.php
+++ b/dist-persist/wbstack/src/Settings/Hooks.php
@@ -1,5 +1,7 @@
 <?php
 
+use MediaWiki\MediaWikiServices;
+
 //// CUSTOM Sidebar for WBStack
 // https://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar
 $wgHooks['SkinBuildSidebar'][] = function ( $skin, &$sidebar ) use ( $wikiInfo ) {
@@ -68,7 +70,8 @@ private static function scheduleDeferredUpdateIfNeeded() {
                 $options['method'] = 'POST';
                 $options['timeout'] = 5;
                 $options['postData'] = json_encode($data);
-                $request = \MWHttpRequest::factory(
+                $httpRequestFactory = MediaWikiServices::getInstance()->getHttpRequestFactory();
+                $request = $httpRequestFactory->create(
                     'http://' . getenv( 'PLATFORM_API_BACKEND_HOST' ) . '/backend/event/pageUpdateBatch',
                     $options
                 );
diff --git a/dist/wbstack/src/Settings/Hooks.php b/dist/wbstack/src/Settings/Hooks.php
index 804eed34a..654e7cb24 100644
--- a/dist/wbstack/src/Settings/Hooks.php
+++ b/dist/wbstack/src/Settings/Hooks.php
@@ -1,5 +1,7 @@
 <?php
 
+use MediaWiki\MediaWikiServices;
+
 //// CUSTOM Sidebar for WBStack
 // https://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar
 $wgHooks['SkinBuildSidebar'][] = function ( $skin, &$sidebar ) use ( $wikiInfo ) {
@@ -68,7 +70,8 @@ private static function scheduleDeferredUpdateIfNeeded() {
                 $options['method'] = 'POST';
                 $options['timeout'] = 5;
                 $options['postData'] = json_encode($data);
-                $request = \MWHttpRequest::factory(
+                $httpRequestFactory = MediaWikiServices::getInstance()->getHttpRequestFactory();
+                $request = $httpRequestFactory->create(
                     'http://' . getenv( 'PLATFORM_API_BACKEND_HOST' ) . '/backend/event/pageUpdateBatch',
                     $options
                 );