sync.sh: update or install but not both#512
Merged
Merged
Conversation
We should probably either update or install (using the lock file) if it is present but not try to install and then update. In the case that an update is needed because of a change to either composer.json or to a composer.json included from composer-merge-plugin we don't want to try an install only to have it fail (and then the script exit early) This commit therefore also renames the bash ENV var to be clearer
deer-wmde
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably either update or install (using the lock file) if it is present but not try to install and then update. In the case that an update is needed because of a change to either composer.json or to a composer.json included from composer-merge-plugin we don't want to try an install only to have it fail (and then the script exit early)
This commit therefore also renames the bash ENV var to be clearer