You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have to remove the logic behind "flexible breakpoints" and fallback to use static CSS breakpoint because it's annoying, waste of effort and totally fragile.
In Firefox it can work fine and the breakpoint is calculated at480px, but on Chrome it is 450px and weird behaviors occur. This is due to Firefox and Chrome calculate the widths of flex items, scrollbars, subpixel rounding, or default styles differently. In my code, the breakpoint is determined by JavaScript measuring the combined width of the two columns plus a fixed value (col1Width + col2Width + 176). This calculation can yield slightly different results in different browsers.
I prefer consistency, easy to maintain and easy to be reviewed code over over-engineering crap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.