Skip to content

Add complaint link and redesign footer#1012

Merged
dati18 merged 7 commits into
mainfrom
redesign-platform-ui-footer
Aug 14, 2025
Merged

Add complaint link and redesign footer#1012
dati18 merged 7 commits into
mainfrom
redesign-platform-ui-footer

Conversation

@dati18
Copy link
Copy Markdown
Contributor

@dati18 dati18 commented Jul 15, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1012/merge will be at the following locations (when build is done):

@dati18
Copy link
Copy Markdown
Contributor Author

dati18 commented Aug 3, 2025

I have to remove the logic behind "flexible breakpoints" and fallback to use static CSS breakpoint because it's annoying, waste of effort and totally fragile.
In Firefox it can work fine and the breakpoint is calculated at480px, but on Chrome it is 450px and weird behaviors occur. This is due to Firefox and Chrome calculate the widths of flex items, scrollbars, subpixel rounding, or default styles differently. In my code, the breakpoint is determined by JavaScript measuring the combined width of the two columns plus a fixed value (col1Width + col2Width + 176). This calculation can yield slightly different results in different browsers.
I prefer consistency, easy to maintain and easy to be reviewed code over over-engineering crap.

Sorry for reading my vent :(

@rosalieper
Copy link
Copy Markdown
Contributor

I wonder why I see already merged changes in your PR. could you try rebasing please? The form is a merged change and it is part of your change.

@dati18 dati18 force-pushed the redesign-platform-ui-footer branch from faf7240 to c1d33e1 Compare August 14, 2025 09:46
@dati18 dati18 merged commit c3efa92 into main Aug 14, 2025
7 checks passed
@dati18 dati18 deleted the redesign-platform-ui-footer branch August 14, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants