eslint: require trailing comma on multiline objects and arrays #1110
Merged
Conversation
|
Deployment previews on netlify for branch
|
Member
Author
|
Keeping as WIP until #1108 is merged |
outdooracorn
force-pushed
the
eslint-comma-dangle
branch
from
70363b9 to
cc3d71b
Compare
Member
Author
|
Ready for review now rebased on |
outdooracorn
requested review from
rosalieper and
tarrow
and removed request for
tarrow
outdooracorn
force-pushed
the
eslint-comma-dangle
branch
from
cc3d71b to
cd5e6b8
Compare
This is benefitial for the following reasons: * improves clarity of diffs when an item is added or removed from an object or array * reduces the chances of having merge conficts, since only the lines you are modifying are touched * simplifies adding and removing items to objects and arrays, since only the lines you are modifying must be touched
outdooracorn
force-pushed
the
eslint-comma-dangle
branch
from
cd5e6b8 to
830ff80
Compare
tarrow
reviewed
Mar 27, 2026
tarrow
approved these changes
Mar 27, 2026
Contributor
|
Replicated steps to lint it and looks good to me. I'm also keen on this idea for the reasons mentioned in the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is beneficial for the following reasons:
Bug: T420768