DSA Info page#1128
Conversation
|
Deployment previews on netlify for branch
|
dati18
left a comment
dati18
left a comment
There was a problem hiding this comment.
I added a few comments but the e2e test is still "red" so I will move this back to TODO
| <p>To contact us in accordance with Article 12 DSA, users can send their | ||
| DSA-related inquiries to our central contact point here <a | ||
| href="mailto:dsa-meldung@wikimedia.de">dsa-meldung@wikimedia.de</a> or | ||
| via telephone (+49 (0)30-577 11 62-0).</p> |
There was a problem hiding this comment.
This phone number is merely a plain text. Consider using a clickable phone link (e.g., an <a href="tel:...">)
There was a problem hiding this comment.
Good thinking, that would make it easier for a user to quickly contact via phone. Great if you want to offer services, but I think if someone needs some legal contact they will reach out anyway + this would make it easier to crawl this phone number by scripts, so I don't think we necessarily want a link like that here
| (1,337,000 in Aug | ||
| 2025-Jan 2026). With 337 monthly editors on Wikibase Cloud and 25,000 on | ||
| Wikidata in January 2026, this results in an estimated average of | ||
| approximately 18,000 monthly active users in the EU for Wikibase |
There was a problem hiding this comment.
line 101 said 20,000. We can flag this up to Anton and confirm.
| </template> | ||
|
|
||
| <script> | ||
| export default { |
There was a problem hiding this comment.
Should we remove it completely? It's empty and provides no value anyway
There was a problem hiding this comment.
fair question, in my mind I rather would leave it here as a reminder of how these templates work/are structured, or what could be added here
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
Looking good so far. Found a few issues and differences from the Figma design.
| <v-row justify="center"> | ||
| <v-col cols="11" md="4" order-md="last"> | ||
| <div class="px-6 py-4"> | ||
| <router-link :to="{ hash: '#dsa-de' }" class="text-decoration-none">Zur deutschen Fassung</router-link> |
There was a problem hiding this comment.
Nice, TIL about router-link!
| Contents | ||
| </v-expansion-panel-header> | ||
|
|
||
| <v-expansion-panel-content> |
There was a problem hiding this comment.
The Figma design has the contents expanded by default on desktop and collapsed by default on mobile. Did you try to implement this? Was this difficult to achieve?
There was a problem hiding this comment.
Ooh I didn't even catch that. I found a way to do it and added it
|
|
||
| <v-col cols="11" md="8"> | ||
| <p class="text-h6 font-weight-regular">English</p> | ||
| <p>The Digital Services Act (DSA) is an EU regulation that entered into force in 2022, establishing a |
There was a problem hiding this comment.
On mobile (375px wide) the lines in this paragraph are wrapped differently depending on if the Contents is expanded or collapsed which is a little jarring. Probably not worth spending too much time on, but if it's an easy fix let's do it.
There was a problem hiding this comment.
I definitely saw what you described, and had no idea how to fix it, but apparently the v-divider fix fixed this as well :D
| </v-row> | ||
|
|
||
| <DsaEnglish id="dsa-en" /> | ||
| <v-divider class="mt-16 mb-8" /> |
There was a problem hiding this comment.
This v-divider isn't rendering properly between the two language sections (for me in the docker composer dev env). Looking in the dev tools, it is rendered to the right of the third English heading and is only 12px wide.
There was a problem hiding this comment.
ah good catch, I wrapped it now like the heading
3 participants
https://phabricator.wikimedia.org/T408254
Bug: T408254