Skip to content

Use state for wiki profile card#982

Merged
AndrewKostka merged 1 commit into
mainfrom
wiki-profile-use-state
May 19, 2025
Merged

Use state for wiki profile card#982
AndrewKostka merged 1 commit into
mainfrom
wiki-profile-use-state

Conversation

@AndrewKostka
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/982/merge will be at the following locations (when build is done):

computed: {
hasProfile: function () {
return !!this.profile.updated_at
return !!this.profile?.updated_at
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; only played with the "unhappy" path since there is no mock backend for successfully saving the updated profile.

Maybe we want to look at adding that later when we do T394521 ?

@AndrewKostka
Copy link
Copy Markdown
Contributor Author

lgtm; only played with the "unhappy" path since there is no mock backend for successfully saving the updated profile.

For now, you can test this patch using the Netlify production preview.

Maybe we want to look at adding that later when we do T394521 ?

We should do that.

@tarrow
Copy link
Copy Markdown
Contributor

tarrow commented May 19, 2025

Yeah, I went back and checked it worked for me. I also double checked that my Profile was there in the db with by manually poking around with tinker. Still all looks good to me and the approval stands; happy to see it merged whenever :)

@AndrewKostka AndrewKostka merged commit 316164c into main May 19, 2025
8 checks passed
@AndrewKostka AndrewKostka deleted the wiki-profile-use-state branch May 19, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants