Support HTTP headers#79
Open
ghost wants to merge 3 commits into
Open
Conversation
Owner
|
@Versalife Thank you so much for contributing this. Should the http headers by passed via the |
Author
|
That would be better yeah, I agree. I'll have a go at making that change |
Owner
|
ok, let me know, I could take a swing at it too.
…On Sun 29 Jul 2018 at 17:33, VersaLife ***@***.***> wrote:
That would be better yeah, I agree. I'll have a go at making that change
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#79 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASr1gDmFc62ZfQDIO_6uAa8wz6_rZY4ks5uLdWugaJpZM4VPjIW>
.
|
Author
|
That's done - I've just changed the interface of the component and left the CacheManager to deal with the uri and headers only to keep things simple. |
|
@wcandillon can you resolve the conflict and merge this pr, I would like to see this change come through :) |
Owner
|
@Versalife Sorry for taking so much time on this. Could you rebase your PR with the latest version of the module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for HTTP headers when fetching an image via the
headersprop, as you would be able to do with theheadersoption for thesourceprop for RN Image.