Skip to content

Support HTTP headers#79

Open
ghost wants to merge 3 commits into
wcandillon:masterfrom
Orclyx:http-headers
Open

Support HTTP headers#79
ghost wants to merge 3 commits into
wcandillon:masterfrom
Orclyx:http-headers

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 13, 2018

Adds support for HTTP headers when fetching an image via the headers prop, as you would be able to do with the headers option for the source prop for RN Image.

@wcandillon
Copy link
Copy Markdown
Owner

@Versalife Thank you so much for contributing this. Should the http headers by passed via the header property of source? This would mean that now the source would be source not URI, which would make it a bit more symetric with <Image> and then it would support this change, do you agree?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2018

That would be better yeah, I agree. I'll have a go at making that change

@wcandillon
Copy link
Copy Markdown
Owner

wcandillon commented Jul 29, 2018 via email

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2018

That's done - I've just changed the interface of the component and left the CacheManager to deal with the uri and headers only to keep things simple.

@AlessandroAries
Copy link
Copy Markdown

@wcandillon can you resolve the conflict and merge this pr, I would like to see this change come through :)

@wcandillon
Copy link
Copy Markdown
Owner

@Versalife Sorry for taking so much time on this. Could you rebase your PR with the latest version of the module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants