🔧

Author: wcandillon

packages/webgpu/apple/RNWGUIKit.h

@@ -13,4 +13,4 @@ typedef UIView RNWGPlatformView;
 typedef NSView RNWGPlatformView;
 #endif
 
-#endif  // PACKAGES_WEBGPU_APPLE_RNWGUIKIT_H_
+#endif // PACKAGES_WEBGPU_APPLE_RNWGUIKIT_H_

packages/webgpu/cpp/jsi/RNFHybridObject.h

@@ -65,6 +65,12 @@ class HybridObject : public jsi::HostObject, public std::enable_shared_from_this
    */
   virtual std::string toString(jsi::Runtime& runtime);
 
+  /**
+   * Get the memory pressure of this HostObject in bytes.
+   * This is used to inform the JavaScript runtime about memory usage for garbage collection.
+   */
+  virtual size_t getMemoryPressure() { return 1024; }
+
 private:
   static constexpr auto TAG = "HybridObject";
   int _instanceId = 1;

packages/webgpu/cpp/jsi/RNFJSIConverter.h

@@ -446,7 +446,12 @@ template <typename T> struct JSIConverter<T, std::enable_if_t<is_shared_ptr_to_h
       throw jsi::JSError(runtime, "Cannot convert nullptr to HostObject<" + getFriendlyTypename() + ">!");
     }
 #endif
-    return jsi::Object::createFromHostObject(runtime, arg);
+    auto result = jsi::Object::createFromHostObject(runtime, arg);
+    auto memoryPressure = arg->getMemoryPressure();
+    if (memoryPressure > 0) {
+      result.setExternalMemoryPressure(runtime, memoryPressure);
+    }
+    return result;
   }
 };
 

packages/webgpu/cpp/rnwgpu/api/GPUBindGroup.h

@@ -37,6 +37,13 @@ class GPUBindGroup : public m::HybridObject {
 
   inline const wgpu::BindGroup get() { return _instance; }
 
+  size_t getMemoryPressure() override {
+    // Bind groups store resource bindings and descriptor state
+    // They reference buffers, textures, samplers, etc.
+    // Estimate: 1KB per bind group (descriptor tables and binding state)
+    return 1024;
+  }
+
 private:
   wgpu::BindGroup _instance;
   std::string _label;

packages/webgpu/cpp/rnwgpu/api/GPUBindGroupLayout.h

@@ -38,6 +38,13 @@ class GPUBindGroupLayout : public m::HybridObject {
 
   inline const wgpu::BindGroupLayout get() { return _instance; }
 
+  size_t getMemoryPressure() override {
+    // Bind group layouts define the structure/schema for bind groups
+    // They store binding descriptors, types, and validation info
+    // Estimate: 512 bytes per layout (smaller than actual bind groups)
+    return 512;
+  }
+
 private:
   wgpu::BindGroupLayout _instance;
   std::string _label;

packages/webgpu/cpp/rnwgpu/api/GPUBuffer.h

@@ -62,6 +62,8 @@ class GPUBuffer : public m::HybridObject {
 
   inline const wgpu::Buffer get() { return _instance; }
 
+  size_t getMemoryPressure() override { return static_cast<size_t>(getSize()); }
+
 private:
   wgpu::Buffer _instance;
   std::shared_ptr<AsyncRunner> _async;

packages/webgpu/cpp/rnwgpu/api/GPUCanvasContext.cpp

@@ -1,7 +1,7 @@
 #include "GPUCanvasContext.h"
-#include <memory>
 #include "Convertors.h"
 #include "RNWebGPUManager.h"
+#include <memory>
 
 #ifdef __APPLE__
 #include "dawn/native/MetalBackend.h"

packages/webgpu/cpp/rnwgpu/api/GPUComputePipeline.h

@@ -45,6 +45,13 @@ class GPUComputePipeline : public m::HybridObject {
 
   inline const wgpu::ComputePipeline get() { return _instance; }
 
+  size_t getMemoryPressure() override {
+    // Compute pipelines contain compiled compute shader state and
+    // driver-specific optimized code
+    // Estimate: 16KB for a typical compute pipeline (single compute shader)
+    return 16 * 1024;
+  }
+
 private:
   wgpu::ComputePipeline _instance;
   std::string _label;

packages/webgpu/cpp/rnwgpu/api/GPUQuerySet.h

@@ -44,6 +44,27 @@ class GPUQuerySet : public m::HybridObject {
 
   inline const wgpu::QuerySet get() { return _instance; }
 
+  size_t getMemoryPressure() override {
+    uint32_t count = getCount();
+    wgpu::QueryType type = getType();
+
+    // Estimate bytes per query based on type
+    size_t bytesPerQuery = 8; // Default estimate
+    switch (type) {
+    case wgpu::QueryType::Occlusion:
+      bytesPerQuery = 8; // 64-bit counter
+      break;
+    case wgpu::QueryType::Timestamp:
+      bytesPerQuery = 8; // 64-bit timestamp
+      break;
+    default:
+      bytesPerQuery = 8; // Safe default
+      break;
+    }
+
+    return static_cast<size_t>(count) * bytesPerQuery;
+  }
+
 private:
   wgpu::QuerySet _instance;
   std::string _label;

packages/webgpu/cpp/rnwgpu/api/GPUQueue.cpp

@@ -40,7 +40,8 @@ void GPUQueue::writeBuffer(std::shared_ptr<GPUBuffer> buffer,
 
   // Note that in the JS semantics of WebGPU, writeBuffer works in number of
   // elements of the typed arrays.
-  if (dataOffsetElements > static_cast<uint64_t>(src.size / src.bytesPerElement)) {
+  if (dataOffsetElements >
+      static_cast<uint64_t>(src.size / src.bytesPerElement)) {
     throw std::runtime_error("dataOffset is larger than data's size.");
     return;
   }