fix(🐛): avoid spurious Hermes GC cycles from canvas texture memory pressure (#341)

Author: wcandillon

apps/example/ios/Podfile.lock

@@ -1865,7 +1865,7 @@ PODS:
     - ReactCommon/turbomodule/core
     - SocketRocket
     - Yoga
-  - react-native-wgpu (0.5.8):
+  - react-native-wgpu (0.5.10):
     - boost
     - DoubleConversion
     - fast_float
@@ -2937,8 +2937,8 @@ SPEC CHECKSUMS:
   React-Mapbuffer: 9d2434a42701d6144ca18f0ca1c4507808ca7696
   React-microtasksnativemodule: 75b6604b667d297292345302cc5bfb6b6aeccc1b
   react-native-safe-area-context: c00143b4823773bba23f2f19f85663ae89ceb460
-  react-native-skia: 3dab14f6a3de3c479a73d87cb1f9aa9556dcec13
-  react-native-wgpu: 32f373d5a9ee83fad1cdddd288bb0738cb97e0ba
+  react-native-skia: 888a5bf5ed5008ae9593990e7dc2ea022b9aea11
+  react-native-wgpu: 1ec8f2457ce741ac80bf5bf7b33e13c3c76c7b2a
   React-NativeModulesApple: 879fbdc5dcff7136abceb7880fe8a2022a1bd7c3
   React-oscompat: 93b5535ea7f7dff46aaee4f78309a70979bdde9d
   React-perflogger: 5536d2df3d18fe0920263466f7b46a56351c0510

packages/webgpu/cpp/rnwgpu/api/GPUCanvasContext.cpp

@@ -48,7 +48,9 @@ std::shared_ptr<GPUTexture> GPUCanvasContext::getCurrentTexture() {
     _surfaceInfo->reconfigure(width, height);
   }
   auto texture = _surfaceInfo->getCurrentTexture();
-  return std::make_shared<GPUTexture>(texture, "");
+  // Pass reportsMemoryPressure=false to avoid triggering spurious Hermes GC
+  // cycles every frame since the canvas texture doesn't own the buffer.
+  return std::make_shared<GPUTexture>(texture, "", false);
 }
 
 void GPUCanvasContext::present() {

packages/webgpu/cpp/rnwgpu/api/GPUTexture.h

@@ -21,8 +21,10 @@ class GPUTexture : public NativeObject<GPUTexture> {
 public:
   static constexpr const char *CLASS_NAME = "GPUTexture";
 
-  explicit GPUTexture(wgpu::Texture instance, std::string label)
-      : NativeObject(CLASS_NAME), _instance(instance), _label(label) {}
+  explicit GPUTexture(wgpu::Texture instance, std::string label,
+                      bool reportsMemoryPressure = true)
+      : NativeObject(CLASS_NAME), _instance(instance), _label(label),
+        _reportsMemoryPressure(reportsMemoryPressure) {}
 
 public:
   std::string getBrand() { return CLASS_NAME; }
@@ -68,6 +70,9 @@ class GPUTexture : public NativeObject<GPUTexture> {
   inline const wgpu::Texture get() { return _instance; }
 
   size_t getMemoryPressure() override {
+    if (!_reportsMemoryPressure) {
+      return sizeof(GPUTexture);
+    }
     // Calculate approximate memory usage based on texture properties
     uint32_t width = getWidth();
     uint32_t height = getHeight();
@@ -85,6 +90,7 @@ class GPUTexture : public NativeObject<GPUTexture> {
     case wgpu::TextureFormat::R8Snorm:
     case wgpu::TextureFormat::R8Uint:
     case wgpu::TextureFormat::R8Sint:
+    case wgpu::TextureFormat::Stencil8:
       bytesPerPixel = 1;
       break;
     case wgpu::TextureFormat::R16Uint:
@@ -94,6 +100,7 @@ class GPUTexture : public NativeObject<GPUTexture> {
     case wgpu::TextureFormat::RG8Snorm:
     case wgpu::TextureFormat::RG8Uint:
     case wgpu::TextureFormat::RG8Sint:
+    case wgpu::TextureFormat::Depth16Unorm:
       bytesPerPixel = 2;
       break;
     case wgpu::TextureFormat::RGBA8Unorm:
@@ -110,6 +117,9 @@ class GPUTexture : public NativeObject<GPUTexture> {
     case wgpu::TextureFormat::RG16Uint:
     case wgpu::TextureFormat::RG16Sint:
     case wgpu::TextureFormat::RG16Float:
+    case wgpu::TextureFormat::Depth24Plus:
+    case wgpu::TextureFormat::Depth24PlusStencil8:
+    case wgpu::TextureFormat::Depth32Float:
       bytesPerPixel = 4;
       break;
     case wgpu::TextureFormat::RG32Float:
@@ -118,6 +128,7 @@ class GPUTexture : public NativeObject<GPUTexture> {
     case wgpu::TextureFormat::RGBA16Uint:
     case wgpu::TextureFormat::RGBA16Sint:
     case wgpu::TextureFormat::RGBA16Float:
+    case wgpu::TextureFormat::Depth32FloatStencil8:
       bytesPerPixel = 8;
       break;
     case wgpu::TextureFormat::RGBA32Float:
@@ -145,6 +156,7 @@ class GPUTexture : public NativeObject<GPUTexture> {
 private:
   wgpu::Texture _instance;
   std::string _label;
+  bool _reportsMemoryPressure = true;
 };
 
 } // namespace rnwgpu

packages/webgpu/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-wgpu",
-  "version": "0.5.9",
+  "version": "0.5.10",
   "description": "React Native WebGPU",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",