Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "react-native-webgpu",
"name": "react-native-webgpu-monorepo",
"private": true,
"workspaces": [
"packages/*",
Expand Down
8 changes: 8 additions & 0 deletions packages/webgpu/cpp/rnwgpu/api/ImageBitmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,17 @@ class ImageBitmap : public NativeObject<ImageBitmap> {

size_t getSize() { return _imageData.data.size(); }

void close() {
_imageData.data.clear();
_imageData.data.shrink_to_fit();
_imageData.width = 0;
_imageData.height = 0;
}

static void definePrototype(jsi::Runtime &runtime, jsi::Object &prototype) {
installGetter(runtime, prototype, "width", &ImageBitmap::getWidth);
installGetter(runtime, prototype, "height", &ImageBitmap::getHeight);
installMethod(runtime, prototype, "close", &ImageBitmap::close);
}

size_t getMemoryPressure() override { return getSize(); }
Expand Down
2 changes: 1 addition & 1 deletion packages/webgpu/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "react-native-wgpu",
"name": "react-native-webgpu",
"version": "0.5.11",
"description": "React Native WebGPU",
"main": "lib/commonjs/index",
Expand Down
55 changes: 55 additions & 0 deletions packages/webgpu/src/__tests__/ImageData.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,61 @@ describe("Image Bitmap", () => {
expect(result.width).toBe(expected.width);
expect(result.height).toBe(expected.height);
});
itSkipsOnWeb("ImageBitmap.close() zeroes width and height", async () => {
const pngBytes = Array.from(
fs.readFileSync(path.join(__dirname, "./assets/Di-3d.png")),
);
const expected = decodeImage(path.join(__dirname, "./assets/Di-3d.png"));
const result = await client.eval(
({ pngData }) => {
const bytes = new Uint8Array(pngData);
return createImageBitmap(bytes.buffer).then((bmp) => {
const before = { width: bmp.width, height: bmp.height };
bmp.close();
const after = { width: bmp.width, height: bmp.height };
return { before, after };
});
},
{ pngData: pngBytes },
);
expect(result.before.width).toBe(expected.width);
expect(result.before.height).toBe(expected.height);
expect(result.after.width).toBe(0);
expect(result.after.height).toBe(0);
});
itSkipsOnWeb("ImageBitmap.close() is idempotent", async () => {
const pngBytes = Array.from(
fs.readFileSync(path.join(__dirname, "./assets/Di-3d.png")),
);
const result = await client.eval(
({ pngData }) => {
const bytes = new Uint8Array(pngData);
return createImageBitmap(bytes.buffer).then((bmp) => {
bmp.close();
bmp.close();
return { width: bmp.width, height: bmp.height };
});
},
{ pngData: pngBytes },
);
expect(result.width).toBe(0);
expect(result.height).toBe(0);
});
itSkipsOnWeb("ImageBitmap exposes close as a function", async () => {
const pngBytes = Array.from(
fs.readFileSync(path.join(__dirname, "./assets/Di-3d.png")),
);
const result = await client.eval(
({ pngData }) => {
const bytes = new Uint8Array(pngData);
return createImageBitmap(bytes.buffer).then((bmp) => {
return typeof bmp.close;
});
},
{ pngData: pngBytes },
);
expect(result).toBe("function");
});
itSkipsOnWeb(
"createImageBitmap from Uint8Array subarray (byteOffset/byteLength)",
async () => {
Expand Down
29 changes: 23 additions & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3657,9 +3657,9 @@ __metadata:
languageName: node
linkType: hard

"@react-three/fiber@patch:@react-three/fiber@npm%3A9.4.0#./.yarn/patches/@react-three-fiber-npm-9.4.0-77fe8ee9bd.patch::locator=react-native-webgpu%40workspace%3A.":
"@react-three/fiber@patch:@react-three/fiber@npm%3A9.4.0#./.yarn/patches/@react-three-fiber-npm-9.4.0-77fe8ee9bd.patch::locator=react-native-webgpu-monorepo%40workspace%3A.":
version: 9.4.0
resolution: "@react-three/fiber@patch:@react-three/fiber@npm%3A9.4.0#./.yarn/patches/@react-three-fiber-npm-9.4.0-77fe8ee9bd.patch::version=9.4.0&hash=7de131&locator=react-native-webgpu%40workspace%3A."
resolution: "@react-three/fiber@patch:@react-three/fiber@npm%3A9.4.0#./.yarn/patches/@react-three-fiber-npm-9.4.0-77fe8ee9bd.patch::version=9.4.0&hash=7de131&locator=react-native-webgpu-monorepo%40workspace%3A."
dependencies:
"@babel/runtime": ^7.17.8
"@types/react-reconciler": ^0.32.0
Expand Down Expand Up @@ -12877,18 +12877,18 @@ __metadata:
languageName: node
linkType: hard

"react-native-webgpu@workspace:.":
"react-native-webgpu-monorepo@workspace:.":
version: 0.0.0-use.local
resolution: "react-native-webgpu@workspace:."
resolution: "react-native-webgpu-monorepo@workspace:."
dependencies:
"@types/react-native-web": ^0.19.2
turbo: ^2.1.0
languageName: unknown
linkType: soft

"react-native-wgpu@*, react-native-wgpu@workspace:packages/webgpu":
"react-native-webgpu@workspace:packages/webgpu":
version: 0.0.0-use.local
resolution: "react-native-wgpu@workspace:packages/webgpu"
resolution: "react-native-webgpu@workspace:packages/webgpu"
dependencies:
"@types/jest": ^29.5.12
"@types/lodash": ^4.17.5
Expand Down Expand Up @@ -12941,6 +12941,23 @@ __metadata:
languageName: unknown
linkType: soft

"react-native-wgpu@npm:*":
version: 0.5.11
resolution: "react-native-wgpu@npm:0.5.11"
peerDependencies:
react: "*"
react-native: "*"
react-native-reanimated: ">=4.2.1"
react-native-worklets: ">=0.7.2"
peerDependenciesMeta:
react-native-reanimated:
optional: true
react-native-worklets:
optional: true
checksum: f6b7775831163038899d38c41ddb4b4fd7de5c56a8ecc881482c145a6ccbabd97d4e5c7ecacdd1dbd8dced8aa6b9b70a6edc63acf726ce331855f4d30f803634
languageName: node
linkType: hard

"react-native-worklets@npm:0.7.2, react-native-worklets@npm:^0.7.0":
version: 0.7.2
resolution: "react-native-worklets@npm:0.7.2"
Expand Down
Loading