Skip to content

Security: Potential Memory Safety Issue in ArrayBuffer JSI Converter #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

Security: Potential Memory Safety Issue in ArrayBuffer JSI Converter #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a72eef7
fix(webgpu): potential memory safety issue in arraybuffer jsi c
tomaioo May 20, 2026
47e5f3a
Merge branch 'main' into fix/security/potential-memory-safety-issue-i…
wcandillon May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/webgpu/cpp/rnwgpu/ArrayBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@ template <> struct JSIConverter<std::shared_ptr<ArrayBuffer>> {
obj.getProperty(runtime, "byteOffset").asNumber());
auto byteLength = static_cast<size_t>(
obj.getProperty(runtime, "byteLength").asNumber());
if (bytesPerElements <= 0 || bytesPerElements > 8) {
Copy link
Copy Markdown
Owner

@wcandillon wcandillon May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we guard here, should we also guard that this is an integer value?

throw std::runtime_error(
"ArrayBuffer::fromJSI: BYTES_PER_ELEMENT must be a positive "
"integer between 1 and 8");
}
auto bufferSize = arrayBuffer.size(runtime);
if (byteOffset > bufferSize || byteLength > bufferSize - byteOffset) {
throw std::runtime_error(
"ArrayBuffer::fromJSI: byteOffset + byteLength exceeds buffer "
"size");
}
return std::make_shared<ArrayBuffer>(
arrayBuffer.data(runtime) + byteOffset, byteLength,
static_cast<size_t>(bytesPerElements));
Expand Down