Skip to content

Commit 470f26e

Browse files
Fix SQL injection vulnerability in orderby parameter across all helper files
Co-authored-by: iftakharul-islam <88052038+iftakharul-islam@users.noreply.github.com>
1 parent cf22440 commit 470f26e

8 files changed

Lines changed: 24 additions & 8 deletions

File tree

src/Activity/Helper/Activity.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ private function orderby() {
598598
$order[] = $this->tb_activity . '.' . esc_sql($key) . ' ' . esc_sql($value);
599599
}
600600

601-
$this->orderby = "ORDER BY " . implode( ', ', $order);
601+
if ( !empty( $order ) ) {
602+
$this->orderby = "ORDER BY " . implode( ', ', $order );
603+
}
602604

603605
return $this;
604606
}

src/Comment/Helper/Comment.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,9 @@ private function orderby() {
395395
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
396396
}
397397

398-
$this->orderby = "ORDER BY " . implode( ', ', $order);
398+
if ( !empty( $order ) ) {
399+
$this->orderby = "ORDER BY " . implode( ', ', $order );
400+
}
399401

400402
return $this;
401403
}

src/Discussion_Board/Helper/Discussion_Board.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,9 @@ private function orderby() {
690690
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
691691
}
692692

693-
$this->orderby = "ORDER BY " . implode( ', ', $order);
693+
if ( !empty( $order ) ) {
694+
$this->orderby = "ORDER BY " . implode( ', ', $order );
695+
}
694696

695697
return $this;
696698
}

src/File/Helper/File.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,9 @@ private function orderby() {
328328
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
329329
}
330330

331-
$this->orderby = "ORDER BY " . implode( ', ', $order);
331+
if ( !empty( $order ) ) {
332+
$this->orderby = "ORDER BY " . implode( ', ', $order );
333+
}
332334

333335
return $this;
334336
}

src/Milestone/Helper/Milestone.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,9 @@ private function orderby() {
597597
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
598598
}
599599

600-
$this->orderby = "ORDER BY " . implode( ', ', $order);
600+
if ( !empty( $order ) ) {
601+
$this->orderby = "ORDER BY " . implode( ', ', $order );
602+
}
601603

602604
return $this;
603605
}

src/Task/Helper/Task.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1950,7 +1950,9 @@ private function orderby() {
19501950
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
19511951
}
19521952

1953-
$this->orderby = "ORDER BY " . implode( ', ', $order);
1953+
if ( !empty( $order ) ) {
1954+
$this->orderby = "ORDER BY " . implode( ', ', $order );
1955+
}
19541956

19551957
return $this;
19561958
}

src/Task_List/Helper/Task_List.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1002,7 +1002,9 @@ private function orderby() {
10021002
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
10031003
}
10041004

1005-
$this->orderby = "ORDER BY " . implode( ', ', $order);
1005+
if ( !empty( $order ) ) {
1006+
$this->orderby = "ORDER BY " . implode( ', ', $order );
1007+
}
10061008

10071009
return $this;
10081010
}

src/User/Helper/User.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,9 @@ private function orderby() {
221221
$order[] = $tb_pj . '.' . esc_sql($key) . ' ' . esc_sql($value);
222222
}
223223

224-
$this->orderby = "ORDER BY " . implode( ', ', $order);
224+
if ( !empty( $order ) ) {
225+
$this->orderby = "ORDER BY " . implode( ', ', $order );
226+
}
225227

226228
return $this;
227229
}

0 commit comments

Comments
 (0)