feature: 2fa with authenticator apps (recover #1852)#1885
Conversation
2FA framework: TOTP authenticator support, multi-method registry, enrollment / challenge / verify flow, security dashboard section, and extracted login-stage CSS/JS to dedicated wpuf-2fa-login assets. Login audit (docs/login-process-audit.md, Phases 1-3): - Reconciled the two Turnstile settings on `login_form_turnstile`. - Removed dead Turnstile error string and the `form_align` dead pipeline. - New filters: `wpuf_login_turnstile_verify`, `wpuf_login_form_layout_class`, `wpuf_login_layouts`, `wpuf_login_form_template_args`. - New actions: `wpuf_login_show_errors`, `wpuf_login_show_messages`. - Layout class applied server-side (no FOUC); single source of truth for the layout list. - Server-side rendering of customizable labels / placeholders / button / remember-me / lost-password / form heading — fixes a11y, page caches, and silent shortcode-page heading.
- Fire wp_login action after auth cookie in 2FA stage 2 so integrations listening for logins (audit logs, tracking) see successful 2FA logins. - Guard openssl_encrypt() failure in TwoFactor\Crypto::encrypt() to avoid base64-encoding a false return. - Use strict less-than for the PHP version gate so the declared 7.4 minimum is actually accepted. - isset() guard on admin_label in settings API multiselect-card to avoid notices for filter-extended option arrays.
…_authenticator_app
# Conflicts: # readme.txt
|
Warning Review limit reached
More reviews will be available in 15 minutes and 19 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (28)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review: 2FA security posture is strong (AES-256-GCM secrets via HKDF, hashed issued codes, TOTP replay protection, rate limiting, single-use 5-min login tokens, Two items to address before release (not code-fixed here as they're product/migration decisions):
Minor (multisite): |
2 participants
Recovered from #1852 (originally by @sapayth), rebased onto
developwith merge conflicts resolved. Functionality preserved.Supersedes #1852.