Skip to content

Commit 5af29f0

Browse files
committed
Minor refactor
1 parent cd4446b commit 5af29f0

2 files changed

Lines changed: 41 additions & 42 deletions

File tree

src/Weaviate.Client.Tests/Integration/TestRbacRoles.cs

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -80,46 +80,6 @@ [new Permissions.Roles(roleName, null) { Read = true }],
8080
}
8181
}
8282

83-
/// <summary>
84-
/// Tests that create role with namespaces permission round trips (Weaviate 1.38+)
85-
/// </summary>
86-
[Fact]
87-
public async Task CreateRoleWithNamespacesPermission()
88-
{
89-
RequireVersion("1.38.0");
90-
var roleName = MakeRoleName("namespaces");
91-
try
92-
{
93-
await _weaviate.Roles.Delete(roleName, TestContext.Current.CancellationToken);
94-
var created = await _weaviate.Roles.Create(
95-
roleName,
96-
[new Permissions.Namespaces("*") { Manage = true }],
97-
TestContext.Current.CancellationToken
98-
);
99-
Assert.NotNull(created);
100-
Assert.Equal(roleName, created.Name);
101-
Assert.Single(created.Permissions);
102-
var scope = Assert.IsType<Permissions.Namespaces>(created.Permissions.Single());
103-
Assert.True(scope.Manage);
104-
Assert.Equal("*", scope.Resource.Namespace);
105-
106-
var fetched = await _weaviate.Roles.Get(
107-
roleName,
108-
TestContext.Current.CancellationToken
109-
);
110-
Assert.NotNull(fetched);
111-
Assert.Equal(roleName, fetched!.Name);
112-
Assert.Single(fetched.Permissions);
113-
var fetchedScope = Assert.IsType<Permissions.Namespaces>(fetched.Permissions.Single());
114-
Assert.True(fetchedScope.Manage);
115-
Assert.Equal("*", fetchedScope.Resource.Namespace);
116-
}
117-
finally
118-
{
119-
await _weaviate.Roles.Delete(roleName, TestContext.Current.CancellationToken);
120-
}
121-
}
122-
12383
/// <summary>
12484
/// Tests that create role conflict
12585
/// </summary>
@@ -614,4 +574,44 @@ public async Task CreateRoleWithMcpPermission()
614574
await _weaviate.Roles.Delete(roleName, TestContext.Current.CancellationToken);
615575
}
616576
}
577+
578+
/// <summary>
579+
/// Tests that create role with namespaces permission round trips (Weaviate 1.38+)
580+
/// </summary>
581+
[Fact]
582+
public async Task CreateRoleWithNamespacesPermission()
583+
{
584+
RequireVersion("1.38.0");
585+
var roleName = MakeRoleName("namespaces");
586+
try
587+
{
588+
await _weaviate.Roles.Delete(roleName, TestContext.Current.CancellationToken);
589+
var created = await _weaviate.Roles.Create(
590+
roleName,
591+
[new Permissions.Namespaces("*") { Manage = true }],
592+
TestContext.Current.CancellationToken
593+
);
594+
Assert.NotNull(created);
595+
Assert.Equal(roleName, created.Name);
596+
Assert.Single(created.Permissions);
597+
var scope = Assert.IsType<Permissions.Namespaces>(created.Permissions.Single());
598+
Assert.True(scope.Manage);
599+
Assert.Equal("*", scope.Resource.Namespace);
600+
601+
var fetched = await _weaviate.Roles.Get(
602+
roleName,
603+
TestContext.Current.CancellationToken
604+
);
605+
Assert.NotNull(fetched);
606+
Assert.Equal(roleName, fetched!.Name);
607+
Assert.Single(fetched.Permissions);
608+
var fetchedScope = Assert.IsType<Permissions.Namespaces>(fetched.Permissions.Single());
609+
Assert.True(fetchedScope.Manage);
610+
Assert.Equal("*", fetchedScope.Resource.Namespace);
611+
}
612+
finally
613+
{
614+
await _weaviate.Roles.Delete(roleName, TestContext.Current.CancellationToken);
615+
}
616+
}
617617
}

src/Weaviate.Client/Models/Replication.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ public enum ReplicationOperationState
6161

6262
/// <summary>
6363
/// Replica has finished copying and is being integrated as a queryable member of the
64-
/// shard (Weaviate 1.38+; occurs between <see cref="Finalizing"/> and <see cref="Dehydrating"/>).
65-
/// Appended after <see cref="Cancelled"/> to keep existing member values stable.
64+
/// shard. Occurs between <see cref="Finalizing"/> and <see cref="Dehydrating"/>).
6665
/// </summary>
6766
[System.Text.Json.Serialization.JsonStringEnumMemberName("INTEGRATING")]
6867
Integrating,

0 commit comments

Comments
 (0)