feat: add AliasesPermission to RBAC

Author: bevzzz

src/main/java/io/weaviate/client/v1/rbac/api/WeaviatePermission.java

@@ -3,6 +3,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import io.weaviate.client.v1.rbac.model.AliasesPermission;
 import io.weaviate.client.v1.rbac.model.BackupsPermission;
 import io.weaviate.client.v1.rbac.model.CollectionsPermission;
 import io.weaviate.client.v1.rbac.model.DataPermission;
@@ -25,6 +26,7 @@
 @ToString
 public class WeaviatePermission {
   String action;
+  AliasesPermission aliases;
   BackupsPermission backups;
   CollectionsPermission collections;
   DataPermission data;
@@ -39,7 +41,9 @@ public WeaviatePermission(String action) {
 
   public <P extends Permission<P>> WeaviatePermission(String action, Permission<P> perm) {
     this.action = action;
-    if (perm instanceof BackupsPermission) {
+    if (perm instanceof AliasesPermission) {
+      this.aliases = (AliasesPermission) perm;
+    } else if (perm instanceof BackupsPermission) {
       this.backups = (BackupsPermission) perm;
     } else if (perm instanceof CollectionsPermission) {
       this.collections = (CollectionsPermission) perm;

src/main/java/io/weaviate/client/v1/rbac/model/AliasesPermission.java

@@ -0,0 +1,31 @@
+package io.weaviate.client.v1.rbac.model;
+
+import lombok.AllArgsConstructor;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+
+@Getter
+@EqualsAndHashCode(callSuper = true)
+public class AliasesPermission extends Permission<AliasesPermission> {
+  final String alias;
+
+  public AliasesPermission(String alias, Action... actions) {
+    super(actions);
+    this.alias = alias;
+  }
+
+  AliasesPermission(String alias, String action) {
+    this(alias, RbacAction.fromString(Action.class, action));
+  }
+
+  @AllArgsConstructor
+  public enum Action implements RbacAction {
+    CREATE("create_aliases"),
+    READ("read_aliases"),
+    UPDATE("update_aliases"),
+    DELETE("delete_aliases");
+
+    @Getter
+    private final String value;
+  }
+}

src/main/java/io/weaviate/client/v1/rbac/model/Permission.java

@@ -66,7 +66,9 @@ private WeaviatePermission toWeaviate(String action) {
    */
   public static Permission<?> fromWeaviate(WeaviatePermission perm) {
     String action = perm.getAction();
-    if (perm.getBackups() != null) {
+    if (perm.getAliases() != null) {
+      return new AliasesPermission(perm.getAliases().getAlias(), action);
+    } else if (perm.getBackups() != null) {
       return new BackupsPermission(perm.getBackups().getCollection(), action);
     } else if (perm.getCollections() != null) {
       return new CollectionsPermission(perm.getCollections().getCollection(), action);
@@ -126,11 +128,22 @@ private Key(Object object) {
     return result.values().stream().collect(Collectors.toList());
   }
 
+  /**
+   * Create {@link AliasesPermission} for a alias.
+   * <p>
+   * Example:
+   * {@code Permission.backups("Pizza", AliasPermission.Action.MANAGE) }
+   */
+  public static AliasesPermission alias(String alias, AliasesPermission.Action... actions) {
+    checkDeprecation(actions);
+    return new AliasesPermission(alias, actions);
+  }
+
   /**
    * Create {@link BackupsPermission} for a collection.
    * <p>
    * Example:
-   * {@code Permission.backups(BackupsPermission.Action.MANAGE, "Pizza") }
+   * {@code Permission.backups("Pizza", BackupsPermission.Action.MANAGE) }
    */
   public static BackupsPermission backups(String collection, BackupsPermission.Action... actions) {
     checkDeprecation(actions);
@@ -140,7 +153,7 @@ public static BackupsPermission backups(String collection, BackupsPermission.Act
   /**
    * Create {@link ClusterPermission} permission.
    * <p>
-   * Example: {@code Permission.cluster(ClusterPermission.Action.READ, "Pizza") }
+   * Example: {@code Permission.cluster(ClusterPermission.Action.READ) }
    */
   public static ClusterPermission cluster(ClusterPermission.Action... actions) {
     checkDeprecation(actions);

src/test/java/io/weaviate/client/v1/rbac/api/WeaviatePermissionTest.java

@@ -6,6 +6,7 @@
 
 import org.junit.Test;
 
+import io.weaviate.client.v1.rbac.model.AliasesPermission;
 import io.weaviate.client.v1.rbac.model.BackupsPermission;
 import io.weaviate.client.v1.rbac.model.ClusterPermission;
 import io.weaviate.client.v1.rbac.model.CollectionsPermission;
@@ -26,6 +27,10 @@ public class WeaviatePermissionTest {
   @Test
   public void testMergedPermissions() {
     WeaviatePermission[] apiPermissions = {
+        // Create and delete PizzaAlias alias
+        new WeaviatePermission("create_alias", new AliasesPermission("PizzaAlias")),
+        new WeaviatePermission("delete_alias", new AliasesPermission("PizzaAlias")),
+
         // Manage Pizza backups
         new WeaviatePermission("manage_backups", new BackupsPermission("Pizza")),
 
@@ -70,6 +75,7 @@ public void testMergedPermissions() {
     };
 
     Permission<?>[] libraryPermissions = {
+        new AliasesPermission("PizzaAlias", AliasesPermission.Action.CREATE, AliasesPermission.Action.DELETE),
         new BackupsPermission("Pizza", BackupsPermission.Action.MANAGE),
         new DataPermission("Pizza", DataPermission.Action.MANAGE, DataPermission.Action.READ),
         new DataPermission("Songs", DataPermission.Action.UPDATE, DataPermission.Action.DELETE),

src/test/java/io/weaviate/client/v1/rbac/model/PermissionTest.java

@@ -23,6 +23,7 @@
 @RunWith(JParamsTestRunner.class)
 public class PermissionTest {
   public static Object[][] serializationTestCases() {
+    AliasesPermission alias = new AliasesPermission("PizzaAlias", AliasesPermission.Action.CREATE);
     BackupsPermission backups = new BackupsPermission("Pizza", BackupsPermission.Action.MANAGE);
     DataPermission data = new DataPermission("Pizza", DataPermission.Action.MANAGE);
     NodesPermission nodes = new NodesPermission("Pizza", NodesPermission.Action.READ);
@@ -33,6 +34,11 @@ public static Object[][] serializationTestCases() {
     UsersPermission users = new UsersPermission(UsersPermission.Action.READ);
 
     return new Object[][] {
+        {
+            "alias permission",
+            (Supplier<Permission<?>>) () -> alias,
+            new WeaviatePermission("create_backups", alias),
+        },
         {
             "backup permission",
             (Supplier<Permission<?>>) () -> backups,

src/test/java/io/weaviate/integration/tests/rbac/ClientRbacTestSuite.java

@@ -24,6 +24,7 @@
 
 import io.weaviate.client.Config;
 import io.weaviate.client.base.Result;
+import io.weaviate.client.v1.rbac.model.AliasesPermission;
 import io.weaviate.client.v1.rbac.model.BackupsPermission;
 import io.weaviate.client.v1.rbac.model.ClusterPermission;
 import io.weaviate.client.v1.rbac.model.CollectionsPermission;
@@ -133,8 +134,10 @@ public void testCreate(String _name, Supplier<Rbac> rbac) {
     Rbac roles = rbac.get();
     String myRole = roleName("VectorOwner");
     String myCollection = "Pizza";
+    String myCollectionAlias = "PizzaAlias";
 
     Permission<?>[] wantPermissions = new Permission<?>[] {
+        Permission.alias(myCollectionAlias, AliasesPermission.Action.CREATE),
         Permission.backups(myCollection, BackupsPermission.Action.MANAGE),
         Permission.cluster(ClusterPermission.Action.READ),
         Permission.nodes(myCollection, NodesPermission.Action.READ),