Skip to content

Commit 435a503

Browse files
author
Fernando Marino
committed
feat: refactor OidcConfig to use Proxy type and simplify proxy handling
1 parent 907f71b commit 435a503

2 files changed

Lines changed: 8 additions & 27 deletions

File tree

src/main/java/io/weaviate/client6/v1/internal/oidc/OidcConfig.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,13 @@
1010
import java.util.stream.Collectors;
1111
import java.util.stream.Stream;
1212

13-
import static java.util.Objects.requireNonNull;
14-
1513
public record OidcConfig(
1614
String clientId,
1715
String providerMetadata,
1816
Set<String> scopes,
19-
OidcProxy proxy) {
20-
21-
public record OidcProxy(
22-
String scheme,
23-
String host,
24-
int port) {
25-
26-
public OidcProxy(Proxy proxy) {
27-
this(requireNonNull(proxy, "proxy is null").scheme(), proxy.host(), proxy.port());
28-
}
29-
30-
}
17+
Proxy proxy) {
3118

32-
public OidcConfig(String clientId, String providerMetadata, Set<String> scopes, OidcProxy proxy) {
19+
public OidcConfig(String clientId, String providerMetadata, Set<String> scopes, Proxy proxy) {
3320
this.clientId = clientId;
3421
this.providerMetadata = providerMetadata;
3522
this.scopes = scopes != null ? Set.copyOf(scopes) : Collections.emptySet();
@@ -44,7 +31,7 @@ public OidcConfig(String clientId, String providerMetadata, List<String> scopes)
4431
this(clientId, providerMetadata, scopes == null ? null : new HashSet<>(scopes), null);
4532
}
4633

47-
public OidcConfig(String clientId, String providerMetadata, List<String> scopes, OidcProxy proxy) {
34+
public OidcConfig(String clientId, String providerMetadata, List<String> scopes, Proxy proxy) {
4835
this(clientId, providerMetadata, scopes == null ? null : new HashSet<>(scopes), proxy);
4936
}
5037

src/main/java/io/weaviate/client6/v1/internal/oidc/OidcUtils.java

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
package io.weaviate.client6.v1.internal.oidc;
22

3-
import java.io.IOException;
4-
import java.util.Collections;
5-
import java.util.List;
6-
73
import com.google.gson.annotations.SerializedName;
8-
94
import io.weaviate.client6.v1.api.WeaviateOAuthException;
10-
import io.weaviate.client6.v1.internal.rest.DefaultRestTransport;
115
import io.weaviate.client6.v1.internal.rest.Endpoint;
126
import io.weaviate.client6.v1.internal.rest.ExternalEndpoint;
137
import io.weaviate.client6.v1.internal.rest.RestTransport;
148
import io.weaviate.client6.v1.internal.rest.SimpleEndpoint;
159

10+
import java.io.IOException;
11+
import java.util.Collections;
12+
import java.util.List;
13+
1614
public final class OidcUtils {
1715
/** Prevents public initialization. */
1816
private OidcUtils() {
@@ -55,10 +53,6 @@ public static final OidcConfig getConfig(RestTransport transport) {
5553
throw new WeaviateOAuthException("fetch provider metadata", e);
5654
}
5755

58-
OidcConfig.OidcProxy proxy = transport.getProxy() != null
59-
? new OidcConfig.OidcProxy(transport.getProxy())
60-
: null;
61-
62-
return new OidcConfig(openid.clientId(), providerMetadata, openid.scopes(), proxy);
56+
return new OidcConfig(openid.clientId(), providerMetadata, openid.scopes(), transport.getProxy());
6357
}
6458
}

0 commit comments

Comments
 (0)