Skip to content

Commit 6d4da87

Browse files
committed
fix: remove typos in PQ config and add unit tests
1 parent 3994900 commit 6d4da87

2 files changed

Lines changed: 75 additions & 4 deletions

File tree

  • src
    • main/java/io/weaviate/client6/v1/api/collections/quantizers
    • test/java/io/weaviate/client6/v1/internal/json

src/main/java/io/weaviate/client6/v1/api/collections/quantizers/PQ.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public record PQ(
1212
@SerializedName("centroids") Integer centroids,
1313
@SerializedName("segments") Integer segments,
1414
@SerializedName("encoder_type") EncoderType encoderType,
15-
@SerializedName("encoder_distribusion") EncoderDistribution encoderDistribution,
15+
@SerializedName("encoder_distribution") EncoderDistribution encoderDistribution,
1616
@SerializedName("training_limit") Integer trainingLimit,
1717
@SerializedName("bit_compression") Boolean bitCompression) implements Quantization {
1818

@@ -24,15 +24,15 @@ public enum EncoderType {
2424
}
2525

2626
public enum EncoderDistribution {
27-
@SerializedName("log-normal")
28-
NORMAL,
2927
@SerializedName("normal")
28+
NORMAL,
29+
@SerializedName("log-normal")
3030
LOG_NORMAL;
3131
}
3232

3333
@Override
3434
public Quantization.Kind _kind() {
35-
return Quantization.Kind.RQ;
35+
return Quantization.Kind.PQ;
3636
}
3737

3838
@Override

src/test/java/io/weaviate/client6/v1/internal/json/JSONTest.java

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import io.weaviate.client6.v1.api.collections.data.BatchReference;
2929
import io.weaviate.client6.v1.api.collections.data.Reference;
3030
import io.weaviate.client6.v1.api.collections.data.ReferenceAddManyResponse;
31+
import io.weaviate.client6.v1.api.collections.quantizers.PQ;
3132
import io.weaviate.client6.v1.api.collections.rerankers.CohereReranker;
3233
import io.weaviate.client6.v1.api.collections.vectorindex.Distance;
3334
import io.weaviate.client6.v1.api.collections.vectorindex.Flat;
@@ -147,6 +148,76 @@ public static Object[][] testCases() {
147148
}
148149
""",
149150
},
151+
{
152+
VectorConfig.class,
153+
SelfProvidedVectorizer.of(none -> none
154+
.quantization(Quantization.pq(pq -> pq
155+
.centroids(8)
156+
.encoderDistribution(PQ.EncoderDistribution.NORMAL)
157+
.encoderType(PQ.EncoderType.TILE)
158+
.segments(16)
159+
.trainingLimit(1024)
160+
.bitCompression(true)))),
161+
"""
162+
{
163+
"vectorIndexType": "hnsw",
164+
"vectorizer": {"none": {}},
165+
"vectorIndexConfig": {
166+
"pq": {
167+
"enabled": true,
168+
"centroids": 8,
169+
"encoder_distribution": "normal",
170+
"encoder_type": "tile",
171+
"segments": 16,
172+
"training_limit": 1024,
173+
"bit_compression": true
174+
}
175+
}
176+
}
177+
""",
178+
},
179+
{
180+
VectorConfig.class,
181+
SelfProvidedVectorizer.of(none -> none
182+
.quantization(Quantization.sq(sq -> sq
183+
.rescoreLimit(10)
184+
.trainingLimit(1024)
185+
.cache(true)))),
186+
"""
187+
{
188+
"vectorIndexType": "hnsw",
189+
"vectorizer": {"none": {}},
190+
"vectorIndexConfig": {
191+
"sq": {
192+
"enabled": true,
193+
"rescore_limit": 10,
194+
"training_limit": 1024,
195+
"cache": true
196+
}
197+
}
198+
}
199+
""",
200+
},
201+
{
202+
VectorConfig.class,
203+
SelfProvidedVectorizer.of(none -> none
204+
.quantization(Quantization.rq(rq -> rq
205+
.rescoreLimit(10)
206+
.bits(8)))),
207+
"""
208+
{
209+
"vectorIndexType": "hnsw",
210+
"vectorizer": {"none": {}},
211+
"vectorIndexConfig": {
212+
"rq": {
213+
"enabled": true,
214+
"rescore_limit": 10,
215+
"bits": 8
216+
}
217+
}
218+
}
219+
""",
220+
},
150221
{
151222
VectorConfig.class,
152223
SelfProvidedVectorizer.of(none -> none

0 commit comments

Comments
 (0)