ci: run tests in parallel

Reduces test execution time from 1:20min to ~45s

Author: bevzzz

.gitignore

@@ -11,3 +11,5 @@
 target/
 # maven-lombok-plugin
 .factorypath
+# Surefire statistics for optimized execution time
+.surefire-*

pom.xml

@@ -232,6 +232,12 @@
           <version>3.5.4</version>
           <configuration>
             <trimStackTrace>false</trimStackTrace>
+            <parallel>classes</parallel>
+            <forkCount>4</forkCount>
+            <reuseForks>true</reuseForks>
+            <threadCount>1</threadCount>
+            <perCoreThreadCount>true</perCoreThreadCount>
+            <runOrder>balanced</runOrder>
             <argLine>
               <!--
                 Gson (used for JSON serialization) utilizes reflection and needs to be able to access private fields of
@@ -241,12 +247,6 @@
               -->
               --add-opens=java.base/java.lang=ALL-UNNAMED
               </argLine>
-              <properties>
-                <property>
-                  <name>listener</name>
-                  <value>io.weaviate.containers.TestListener</value>
-                </property>
-              </properties>
           </configuration>
         </plugin>
         <plugin>

src/it/java/io/weaviate/containers/Container.java

@@ -18,18 +18,6 @@ public class Container {
   public static final Img2VecNeural IMG2VEC_NEURAL = Img2VecNeural.createDefault();
   public static final MinIo MINIO = MinIo.createDefault();
 
-  /**
-   * Stop all shared Testcontainers created in {@link #startAll}.
-   * <p>
-   * Testcontainer's Ryuk will reap any dangling containers after the tests
-   * finish. However, since {@link Weaviate} instances also hold a
-   * {@link WeaviateClient}, we want to stop them proactively to
-   * close client connections.
-   */
-  static void stopAll() {
-    WEAVIATE.stop();
-  }
-
   public static ContainerGroup compose(Weaviate weaviate, GenericContainer<?>... containers) {
     return new ContainerGroup(weaviate, containers);
   }

src/it/java/io/weaviate/containers/TestListener.java

@@ -49,6 +49,22 @@ public WeaviateClient getClient() {
     return clientInstance;
   }
 
+  /**
+   * Get client that is not shared with other tests / callers.
+   * The returned client is not wrapped in an instance of {@link SharedClient},
+   * so it can be auto-closed by the try-with-resources statement when it exists.
+   */
+  public WeaviateClient getBareClient() {
+    if (!isRunning()) {
+      start();
+    }
+    try {
+      return new WeaviateClient(Config.of(defaultConfigFn()));
+    } catch (Exception e) {
+      throw new RuntimeException("create WeaviateClient for Weaviate container", e);
+    }
+  }
+
   /**
    * Create a new instance of WeaviateClient connected to this container.
    * Prefer using {@link #getClient} unless your test needs the initialization
@@ -138,6 +154,7 @@ public Builder withFilesystemBackup(String fsPath) {
       environment.put("BACKUP_FILESYSTEM_PATH", fsPath);
       return this;
     }
+
     public Builder withAdminUsers(String... admins) {
       adminUsers.addAll(Arrays.asList(admins));
       return this;

src/it/java/io/weaviate/containers/Weaviate.java

@@ -21,6 +21,7 @@
 import io.weaviate.client6.v1.api.collections.vectorindex.Hnsw;
 import io.weaviate.client6.v1.api.collections.vectorizers.SelfProvidedVectorizer;
 import io.weaviate.containers.Container;
+import io.weaviate.containers.Weaviate;
 
 public class CollectionsITest extends ConcurrentTest {
   private static WeaviateClient client = Container.WEAVIATE.getClient();
@@ -95,31 +96,34 @@ public void testCrossReferences() throws IOException {
   }
 
   @Test
-  public void testListDeleteAll() throws IOException {
-    var nsA = ns("A");
-    var nsB = ns("B");
-    var nsC = ns("C");
-
-    client.collections.create(nsA);
-    client.collections.create(nsB);
-    client.collections.create(nsC);
-
-    Assertions.assertThat(client.collections.exists(nsA)).isTrue();
-    Assertions.assertThat(client.collections.exists(nsB)).isTrue();
-    Assertions.assertThat(client.collections.exists(nsC)).isTrue();
-    Assertions.assertThat(client.collections.exists(ns("X"))).isFalse();
-
-    var all = client.collections.list();
-    Assertions.assertThat(all)
-        .hasSizeGreaterThanOrEqualTo(3)
-        .extracting(CollectionConfig::collectionName)
-        .contains(nsA, nsB, nsC);
-
-    client.collections.deleteAll();
-
-    all = client.collections.list();
-    Assertions.assertThat(all.isEmpty());
-
+  public void testListDeleteAll() throws Exception {
+    // Use a separate container for this test so as not to interfere
+    // with other tests.
+    try (final var _client = Weaviate.createDefault().getBareClient()) {
+      var nsA = ns("A");
+      var nsB = ns("B");
+      var nsC = ns("C");
+
+      _client.collections.create(nsA);
+      _client.collections.create(nsB);
+      _client.collections.create(nsC);
+
+      Assertions.assertThat(_client.collections.exists(nsA)).isTrue();
+      Assertions.assertThat(_client.collections.exists(nsB)).isTrue();
+      Assertions.assertThat(_client.collections.exists(nsC)).isTrue();
+      Assertions.assertThat(_client.collections.exists(ns("X"))).isFalse();
+
+      var all = _client.collections.list();
+      Assertions.assertThat(all)
+          .hasSizeGreaterThanOrEqualTo(3)
+          .extracting(CollectionConfig::collectionName)
+          .contains(nsA, nsB, nsC);
+
+      _client.collections.deleteAll();
+
+      all = _client.collections.list();
+      Assertions.assertThat(all.isEmpty());
+    }
   }
 
   @Test

src/it/java/io/weaviate/integration/CollectionsITest.java

@@ -24,11 +24,17 @@ public ReferenceAddManyResponse deserialize(JsonElement json, Type typeOfT, Json
       int i = 0;
       for (var el : json.getAsJsonArray()) {
         var result = el.getAsJsonObject().get("result").getAsJsonObject();
-        if (result.get("status").getAsString().equals("FAILED")) {
-          var errorMsg = result
-              .get("errors").getAsJsonObject()
-              .get("error").getAsJsonArray()
-              .get(0).getAsString();
+        if (result.get("status").getAsString().equals("FAILED")
+            && result.has("errors")) {
+          String errorMsg;
+          try {
+            errorMsg = result
+                .get("errors").getAsJsonObject()
+                .get("error").getAsJsonArray()
+                .get(0).getAsString();
+          } catch (Exception e) {
+            errorMsg = result.get("errors").toString();
+          }
 
           var batchErr = new BatchError(errorMsg, null, i);
           errors.add(batchErr);