Skip to content

Commit 76d5c0e

Browse files
committed
refactor: rename setInteger -> setLong
Consistent with how setDouble() accepts a Double even though the Weaviate's data type is number. PropertyBuilder deals with Java data types so the methods should be named accordingly.
1 parent 132ba34 commit 76d5c0e

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/main/java/io/weaviate/client6/v1/api/collections/query/QueryRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ private static <T> void setProperty(String property, WeaviateProtoProperties.Val
221221
} else if (value.hasBoolValue()) {
222222
builder.setBoolean(property, value.getBoolValue());
223223
} else if (value.hasIntValue()) {
224-
builder.setInteger(property, value.getIntValue());
224+
builder.setLong(property, value.getIntValue());
225225
} else if (value.hasNumberValue()) {
226226
builder.setDouble(property, value.getNumberValue());
227227
} else if (value.hasBlobValue()) {

src/main/java/io/weaviate/client6/v1/internal/orm/MapBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public void setBoolean(String property, Boolean value) {
2525
}
2626

2727
@Override
28-
public void setInteger(String property, Long value) {
28+
public void setLong(String property, Long value) {
2929
properties.put(property, value);
3030
}
3131

src/main/java/io/weaviate/client6/v1/internal/orm/PojoBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ public void setBoolean(String propertyName, Boolean value) {
125125
}
126126

127127
@Override
128-
// TODO: rename to setLong
129-
public void setInteger(String propertyName, Long value) {
128+
public void setLong(String propertyName, Long value) {
130129
if (isType(propertyName, short.class, Short.class)) {
131130
setValue(propertyName, value.shortValue());
132131
} else if (isType(propertyName, int.class, Integer.class)) {

src/main/java/io/weaviate/client6/v1/internal/orm/PropertiesBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public interface PropertiesBuilder<T> {
1111

1212
void setBoolean(String property, Boolean value);
1313

14-
void setInteger(String property, Long value);
14+
void setLong(String property, Long value);
1515

1616
void setDouble(String property, Double value);
1717

0 commit comments

Comments
 (0)