Skip to content

Commit d06831a

Browse files
committed
fix: correct usage of Optional tenant
1 parent 1571d94 commit d06831a

5 files changed

Lines changed: 18 additions & 9 deletions

File tree

src/it/java/io/weaviate/containers/Weaviate.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public enum Version {
4242
V133(1, 33, 11),
4343
V134(1, 34, 7),
4444
V135(1, 35, 2),
45-
V136(1, 36, "0-rc.0");
45+
V136(1, 36, 0);
4646

4747
public final SemanticVersion semver;
4848

@@ -300,6 +300,8 @@ public Weaviate build() {
300300
c.withEnv("ENABLE_MODULES", String.join(",", enableModules));
301301
}
302302

303+
c.withEnv("OBJECTS_TTL_DELETE_SCHEDULE", "0 */6 * * *");
304+
303305
var apiKeyUsers = new HashSet<String>();
304306
apiKeyUsers.addAll(adminUsers);
305307
apiKeyUsers.addAll(viewerUsers);

src/main/java/io/weaviate/client6/v1/api/collections/data/InsertObjectRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static final <PropertiesT> Endpoint<InsertObjectRequest<PropertiesT>, Wea
3434
new WeaviateObject<>(
3535
request.object.uuid(),
3636
collection.collectionName(),
37-
defaults.tenant().get(),
37+
defaults.tenant().orElse(null),
3838
request.object.properties(),
3939
request.object.vectors(),
4040
request.object.createdAt(),

src/main/java/io/weaviate/client6/v1/api/collections/data/ReplaceObjectRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ static final <PropertiesT> Endpoint<ReplaceObjectRequest<PropertiesT>, Void> end
3333
new WeaviateObject<>(
3434
request.object.uuid(),
3535
collection.collectionName(),
36-
defaults.tenant().get(),
36+
defaults.tenant().orElse(null),
3737
request.object.properties(),
3838
request.object.vectors(),
3939
request.object.createdAt(),

src/main/java/io/weaviate/client6/v1/api/collections/data/UpdateObjectRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ static final <PropertiesT> Endpoint<UpdateObjectRequest<PropertiesT>, Void> endp
3333
new WeaviateObject<>(
3434
request.object.uuid(),
3535
collection.collectionName(),
36-
defaults.tenant().get(),
36+
defaults.tenant().orElse(null),
3737
request.object.properties(),
3838
request.object.vectors(),
3939
request.object.createdAt(),

src/test/java/io/weaviate/client6/v1/api/collections/CollectionHandleDefaultsTest.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,32 @@
77

88
import io.weaviate.client6.v1.api.collections.query.ConsistencyLevel;
99
import io.weaviate.client6.v1.internal.ObjectBuilder;
10+
import io.weaviate.client6.v1.internal.grpc.GrpcTransport;
1011
import io.weaviate.client6.v1.internal.orm.CollectionDescriptor;
12+
import io.weaviate.client6.v1.internal.rest.RestTransport;
13+
import io.weaviate.testutil.transport.MockGrpcTransport;
14+
import io.weaviate.testutil.transport.MockRestTransport;
1115

1216
public class CollectionHandleDefaultsTest {
1317
private static final CollectionDescriptor<Map<String, Object>> DESCRIPTOR = CollectionDescriptor.ofMap("Things");
1418
private static final CollectionHandleDefaults NONE_DEFAULTS = CollectionHandleDefaults.of(ObjectBuilder.identity());
1519

20+
private static final RestTransport REST = new MockRestTransport();
21+
private static final GrpcTransport GRPC = new MockGrpcTransport();
22+
1623
/** CollectionHandle with no defaults. */
1724
private static final CollectionHandle<Map<String, Object>> HANDLE_NONE = new CollectionHandle<>(
18-
null, null, DESCRIPTOR, NONE_DEFAULTS);
25+
REST, GRPC, DESCRIPTOR, NONE_DEFAULTS);
1926

2027
/** CollectionHandleAsync with no defaults. */
2128
private static final CollectionHandleAsync<Map<String, Object>> HANDLE_NONE_ASYNC = new CollectionHandleAsync<>(
22-
null, null, DESCRIPTOR, NONE_DEFAULTS);
29+
REST, GRPC, DESCRIPTOR, NONE_DEFAULTS);
2330

2431
/** All defaults are {@code null} if none were set. */
2532
@Test
2633
public void test_defaults() {
2734
Assertions.assertThat(HANDLE_NONE.consistencyLevel()).as("default ConsistencyLevel").isEmpty();
28-
Assertions.assertThat(HANDLE_NONE.tenant()).as("default tenant").isNull();
35+
Assertions.assertThat(HANDLE_NONE.tenant()).as("default tenant").isEmpty();
2936
}
3037

3138
/**
@@ -57,7 +64,7 @@ public void test_withConsistencyLevel_async() {
5764
@Test
5865
public void test_withTenant() {
5966
var handle = HANDLE_NONE.withTenant("john_doe");
60-
Assertions.assertThat(handle.tenant()).isEqualTo("john_doe");
67+
Assertions.assertThat(handle.tenant()).get().isEqualTo("john_doe");
6168
Assertions.assertThat(HANDLE_NONE.consistencyLevel()).isEmpty();
6269
}
6370

@@ -68,7 +75,7 @@ public void test_withTenant() {
6875
@Test
6976
public void test_withTenant_async() {
7077
var handle = HANDLE_NONE_ASYNC.withTenant("john_doe");
71-
Assertions.assertThat(handle.tenant()).isEqualTo("john_doe");
78+
Assertions.assertThat(handle.tenant()).get().isEqualTo("john_doe");
7279
Assertions.assertThat(HANDLE_NONE_ASYNC.consistencyLevel()).isEmpty();
7380
}
7481
}

0 commit comments

Comments
 (0)