Address PR review feedback (round 5)

jfrancoa · claude · jfrancoa · commit 065c6fc6c05e · 2026-05-05T15:03:34.000+02:00
- Guard create_export against a None return from the client with a
  clean ClickException, instead of relying on an inconsistent
  half-check that would AttributeError on later dereferences.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/weaviate_cli/managers/export_manager.py b/weaviate_cli/managers/export_manager.py
@@ -82,7 +82,12 @@ def create_export(
             wait_for_completion=wait,
         )
 
-        if wait and result and result.status.value != "SUCCESS":
+        if result is None:
+            raise click.ClickException(
+                f"Export '{export_id}' did not return a result from the server."
+            )
+
+        if wait and result.status.value != "SUCCESS":
             raise click.ClickException(
                 f"Export '{export_id}' finished with status '{result.status.value}'."
             )

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,12 @@ def create_export(`
`82`	`82`	`wait_for_completion=wait,`
`83`	`83`	`)`
`84`	`84`
`85`		`- if wait and result and result.status.value != "SUCCESS":`
	`85`	`+ if result is None:`
	`86`	`+ raise click.ClickException(`
	`87`	`+ f"Export '{export_id}' did not return a result from the server."`
	`88`	`+ )`
	`89`	`+`
	`90`	`+ if wait and result.status.value != "SUCCESS":`
`86`	`91`	`raise click.ClickException(`
`87`	`92`	`f"Export '{export_id}' finished with status '{result.status.value}'."`
`88`	`93`	`)`