Skip to content

Commit 3d4a8a7

Browse files
jfrancoaclaude
andcommitted
Address PR review feedback (round 2)
- Add --async_enabled prerequisite to help text, SKILL.md, and collections.md - Point weaviate-client dependency to jose/fix-async-repl-config-get branch - Update setup.cfg install_requires to match - Change minimum version to 1.34.18 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7bd28c8 commit 3d4a8a7

4 files changed

Lines changed: 9 additions & 8 deletions

File tree

.claude/skills/operating-weaviate-cli/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,14 @@ weaviate-cli delete collection --collection MyCollection --json
139139
weaviate-cli delete collection --all --json
140140
```
141141

142-
Key create options: `--multitenant`, `--auto_tenant_creation`, `--auto_tenant_activation`, `--shards N`, `--vectorizer <type>`, `--named_vector`, `--replication_deletion_strategy`, `--async_replication_config key=value` (repeatable; requires `--async_enabled` and Weaviate >= v1.36.0), `--object_ttl_type`, `--object_ttl_time`, `--object_ttl_filter_expired`, `--object_ttl_property_name` (only when `object_ttl_type=property`)
142+
Key create options: `--multitenant`, `--auto_tenant_creation`, `--auto_tenant_activation`, `--shards N`, `--vectorizer <type>`, `--named_vector`, `--replication_deletion_strategy`, `--async_replication_config key=value` (repeatable; requires `--async_enabled` and Weaviate >= v1.34.18), `--object_ttl_type`, `--object_ttl_time`, `--object_ttl_filter_expired`, `--object_ttl_property_name` (only when `object_ttl_type=property`)
143143

144144
Mutable fields: `--async_enabled`, `--replication_factor`, `--vector_index`, `--description`, `--training_limit`, `--auto_tenant_creation`, `--auto_tenant_activation`, `--replication_deletion_strategy`, `--async_replication_config key=value` (repeatable), `--object_ttl_type`, `--object_ttl_time`, `--object_ttl_filter_expired`, `--object_ttl_property_name` (only when `object_ttl_type=property`)
145145

146146
#### Async Replication Config
147147

148148
```bash
149-
# Create with async replication tuning (requires --async_enabled and Weaviate >= v1.36.0)
149+
# Create with async replication tuning (requires --async_enabled and Weaviate >= v1.34.18)
150150
weaviate-cli create collection --collection MyCol --async_enabled \
151151
--async_replication_config max_workers=10 \
152152
--async_replication_config frequency=60 \

.claude/skills/operating-weaviate-cli/references/collections.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ weaviate-cli create collection \
4343
- `--object_ttl_time` -- Time to live in seconds (default: None, TTL disabled when omitted)
4444
- `--object_ttl_filter_expired` -- Filter expired-but-not-yet-deleted objects from queries
4545
- `--object_ttl_property_name` -- Date property name for TTL when `object_ttl_type=property` (default: "releaseDate"). **Only valid when `--object_ttl_type=property`**; rejected otherwise.
46-
- `--async_replication_config` -- Async replication tuning as `key=value` pairs (repeatable). Valid keys: `max_workers`, `hashtree_height`, `frequency`, `frequency_while_propagating`, `alive_nodes_checking_frequency`, `logging_frequency`, `diff_batch_size`, `diff_per_node_timeout`, `pre_propagation_timeout`, `propagation_timeout`, `propagation_limit`, `propagation_delay`, `propagation_concurrency`, `propagation_batch_size`. All values must be integers. Requires `--async_enabled` on create and Weaviate >= v1.36.0.
46+
- `--async_replication_config` -- Async replication tuning as `key=value` pairs (repeatable). Valid keys: `max_workers`, `hashtree_height`, `frequency`, `frequency_while_propagating`, `alive_nodes_checking_frequency`, `logging_frequency`, `diff_batch_size`, `diff_per_node_timeout`, `pre_propagation_timeout`, `propagation_timeout`, `propagation_limit`, `propagation_delay`, `propagation_concurrency`, `propagation_batch_size`. All values must be integers. Use `reset` to revert all to server defaults. Requires `--async_enabled` on create and Weaviate >= v1.34.18.
4747

4848
**Async replication config examples:**
4949
```bash

weaviate_cli/managers/collection_manager.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,9 @@ def create_collection(
249249
"Error: --async_replication_config requires --async_enabled to be set."
250250
)
251251

252-
if async_replication_config and older_than_version(self.client, "1.36.0"):
252+
if async_replication_config and older_than_version(self.client, "1.34.18"):
253253
click.echo(
254-
"Warning: --async_replication_config requires Weaviate >= v1.36.0. "
254+
"Warning: --async_replication_config requires Weaviate >= v1.34.18. "
255255
"The server may ignore or reject these settings."
256256
)
257257

@@ -655,9 +655,9 @@ def update_collection(
655655
"Error: --async_replication_config cannot be used when --async_enabled is False."
656656
)
657657

658-
if async_replication_config and older_than_version(self.client, "1.36.0"):
658+
if async_replication_config and older_than_version(self.client, "1.34.18"):
659659
click.echo(
660-
"Warning: --async_replication_config requires Weaviate >= v1.36.0. "
660+
"Warning: --async_replication_config requires Weaviate >= v1.34.18. "
661661
"The server may ignore or reject these settings."
662662
)
663663

weaviate_cli/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ def pp_objects(response, main_properties, json_output: bool = False):
138138
"Async replication config as key=value pairs. Can be specified multiple times. "
139139
"Valid keys: " + ", ".join(sorted(ASYNC_REPLICATION_CONFIG_KEYS)) + ". "
140140
"All values must be integers. "
141-
"Requires --async_enabled on create and Weaviate >= v1.36.0."
141+
'Use "reset" to revert all async replication settings to server defaults. '
142+
"Requires --async_enabled on create and Weaviate >= v1.34.18."
142143
)
143144

144145

0 commit comments

Comments
 (0)