Address PR review feedback (round 3)

- Use ASYNC_REPLICATION_CONFIG_RESET constant in parser instead of literal
- Remove unused async_replication_config field from CreateCollectionDefaults and UpdateCollectionDefaults
- Reject --async_replication_config 'reset' on create (no semantics for new collections)
- Tighten type annotations: tuple -> Tuple[str, ...]
- Drop trivially-dead `if result else None` return
- Add unit tests for old-version warning path (create + update)
- Add unit test for update reset path asserting Reconfigure.Replication.async_config() is invoked with no kwargs

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: jfrancoa

test/unittests/test_managers/test_collection_manager.py

@@ -1020,3 +1020,97 @@ def test_update_collection_async_replication_config_rejected_when_async_false(
         )
 
     mock_collections.get.return_value.config.update.assert_not_called()
+
+
+def test_create_collection_async_replication_config_warns_on_old_version(
+    mock_client, mock_wvc_object_ttl, capsys
+):
+    """Warn when async_replication_config is used against a server older than v1.34.18."""
+    mock_collections = MagicMock()
+    mock_client.collections = mock_collections
+    mock_collections.exists.side_effect = [False, True]
+    mock_client.get_meta.return_value = {"version": "1.34.0"}
+
+    manager = CollectionManager(mock_client)
+
+    manager.create_collection(
+        collection="TestCollection",
+        replication_factor=3,
+        vector_index="hnsw",
+        async_enabled=True,
+        async_replication_config={"max_workers": 10},
+    )
+
+    captured = capsys.readouterr()
+    assert "Warning: --async_replication_config requires Weaviate >= v1.34.18" in (
+        captured.out + captured.err
+    )
+    mock_collections.create.assert_called_once()
+
+
+def test_update_collection_async_replication_config_reset(
+    mock_client, mock_wvc_object_ttl
+):
+    """Reset (empty dict) calls Reconfigure.Replication.async_config() with no kwargs."""
+    mock_collections = MagicMock()
+    mock_client.collections = mock_collections
+    mock_client.collections.exists.side_effect = [True, True]
+    mock_client.get_meta.return_value = {"version": "1.36.0"}
+
+    mock_collection = MagicMock()
+    mock_client.collections.get.return_value = mock_collection
+    mock_collection.config.get.return_value = MagicMock(
+        replication_config=MagicMock(factor=3),
+        multi_tenancy_config=MagicMock(
+            enabled=False, auto_tenant_creation=False, auto_tenant_activation=False
+        ),
+    )
+
+    manager = CollectionManager(mock_client)
+
+    with patch.object(
+        wvc.Reconfigure.Replication,
+        "async_config",
+        wraps=wvc.Reconfigure.Replication.async_config,
+    ) as mock_async_config:
+        manager.update_collection(
+            collection="TestCollection",
+            async_replication_config={},
+        )
+
+    mock_async_config.assert_called_once_with()
+    mock_collection.config.update.assert_called_once()
+    repl_config = mock_collection.config.update.call_args.kwargs["replication_config"]
+    assert repl_config.asyncConfig is not None
+
+
+def test_update_collection_async_replication_config_warns_on_old_version(
+    mock_client, mock_wvc_object_ttl, capsys
+):
+    """Warn when async_replication_config is used against a server older than v1.34.18."""
+    mock_collections = MagicMock()
+    mock_client.collections = mock_collections
+    mock_client.collections.exists.side_effect = [True, True]
+    mock_client.get_meta.return_value = {"version": "1.34.0"}
+
+    mock_collection = MagicMock()
+    mock_client.collections.get.return_value = mock_collection
+    mock_collection.config.get.return_value = MagicMock(
+        replication_config=MagicMock(factor=3),
+        multi_tenancy_config=MagicMock(
+            enabled=False, auto_tenant_creation=False, auto_tenant_activation=False
+        ),
+    )
+
+    manager = CollectionManager(mock_client)
+
+    manager.update_collection(
+        collection="TestCollection",
+        async_replication_config={"max_workers": 10},
+    )
+
+    captured = capsys.readouterr()
+    assert "Warning: --async_replication_config requires Weaviate >= v1.34.18" in (
+        captured.out + captured.err
+    )
+    mock_collection.config.update.assert_called_once()

weaviate_cli/commands/create.py

@@ -1,6 +1,6 @@
 import sys
 import click
-from typing import Optional
+from typing import Optional, Tuple
 import json
 
 from weaviate import WeaviateClient
@@ -256,7 +256,7 @@ def create_collection_cli(
     object_ttl_time: Optional[int],
     object_ttl_filter_expired: bool,
     object_ttl_property_name: Optional[str],
-    async_replication_config: tuple,
+    async_replication_config: Tuple[str, ...],
 ) -> None:
     """Create a collection in Weaviate."""
 
@@ -272,6 +272,11 @@ def create_collection_cli(
         sys.exit(1)
     client = None
     try:
+        parsed_async_config = parse_async_replication_config(async_replication_config)
+        if parsed_async_config == {}:
+            raise click.UsageError(
+                "--async_replication_config 'reset' is only supported on update, not create."
+            )
         client = get_client_from_context(ctx)
         # Call the function from create_collection.py passing both general and specific arguments
         collection_man = CollectionManager(client)
@@ -302,9 +307,7 @@ def create_collection_cli(
             object_ttl_time=object_ttl_time,
             object_ttl_filter_expired=object_ttl_filter_expired,
             object_ttl_property_name=object_ttl_property_name,
-            async_replication_config=parse_async_replication_config(
-                async_replication_config
-            ),
+            async_replication_config=parsed_async_config,
         )
     except Exception as e:
         click.echo(f"Error: {e}")

weaviate_cli/commands/update.py

@@ -1,7 +1,7 @@
 import sys
 import click
 import json
-from typing import Optional, Union
+from typing import Optional, Tuple, Union
 
 from weaviate_cli.completion.complete import collection_name_complete
 from weaviate_cli.managers.alias_manager import AliasManager
@@ -136,7 +136,7 @@ def update_collection_cli(
     object_ttl_time: Optional[int],
     object_ttl_filter_expired: bool,
     object_ttl_property_name: Optional[str],
-    async_replication_config: tuple,
+    async_replication_config: Tuple[str, ...],
 ) -> None:
     """Update a collection in Weaviate."""
 

weaviate_cli/defaults.py

@@ -87,7 +87,6 @@ class CreateCollectionDefaults:
     object_ttl_time: Optional[int] = None
     object_ttl_filter_expired: Optional[bool] = None
     object_ttl_property_name: str = "releaseDate"
-    async_replication_config: Optional[tuple] = None
 
 
 @dataclass
@@ -264,7 +263,6 @@ class UpdateCollectionDefaults:
     object_ttl_time: Optional[int] = None
     object_ttl_filter_expired: Optional[bool] = None
     object_ttl_property_name: str = "releaseDate"
-    async_replication_config: Optional[tuple] = None
 
 
 @dataclass

weaviate_cli/utils.py

@@ -164,7 +164,10 @@ def parse_async_replication_config(
     if not config_tuples:
         return None
 
-    if len(config_tuples) == 1 and config_tuples[0].strip().lower() == "reset":
+    if (
+        len(config_tuples) == 1
+        and config_tuples[0].strip().lower() == ASYNC_REPLICATION_CONFIG_RESET
+    ):
         return {}
 
     result = {}
@@ -190,7 +193,7 @@ def parse_async_replication_config(
                 f"Invalid value for '{key}': '{value}'. Must be an integer."
             )
 
-    return result if result else None
+    return result
 
 
 def parse_permission(perm: str) -> PermissionsCreateType: