Review feedback

Author: trengrj

integration/test_collection_boost.py

@@ -115,6 +115,7 @@ def test_boost_numeric_decay(collection_factory: CollectionFactory) -> None:
             origin=50.0,
             scale=20.0,
             curve=Boost.Curve.LINEAR,
+            decay=0.5,
             weight=1.0,
         ),
         return_metadata=MetadataQuery(distance=True),
@@ -135,6 +136,7 @@ def test_boost_time_decay(collection_factory: CollectionFactory) -> None:
             origin="2024-01-01T00:00:00Z",
             scale="365d",
             curve=Boost.Curve.EXPONENTIAL,
+            decay=0.3,
             weight=1.0,
         ),
         return_metadata=MetadataQuery(distance=True),

weaviate/collections/classes/grpc.py

@@ -382,7 +382,7 @@ def time_decay(
         scale: Union[str, timedelta],
         offset: Optional[Union[str, timedelta]] = None,
         curve: Optional[Union[_BoostCurve, str]] = None,
-        decay_value: Optional[float] = None,
+        decay: Optional[float] = None,
         weight: Optional[float] = None,
         depth: Optional[int] = None,
     ) -> _Boost:
@@ -392,12 +392,12 @@ def time_decay(
             property: The date property name to compute distance from.
             origin: The origin point. Use "now" for current time or a datetime for a specific time.
                 Defaults to "now".
-            scale: Distance from origin where score equals decay_value. Use timedelta
+            scale: Distance from origin where score equals decay. Use timedelta
                 (e.g. timedelta(days=7)) or a string shorthand like "7d", "24h".
             offset: Documents within this distance from origin get full score (default "0").
                 Accepts the same types as scale.
             curve: Decay curve type: `Boost.Curve.EXPONENTIAL` (default), `Boost.Curve.GAUSSIAN`, or `Boost.Curve.LINEAR`.
-            decay_value: Score at scale distance from origin (default 0.5).
+            decay: Score at scale distance from origin (default 0.5).
             weight: Blending weight [0,1] controlling how much the rank affects final scores.
             depth: Number of results to rescore (default 100, max 10000).
         """
@@ -410,7 +410,7 @@ def time_decay(
                         scale=_decay_value_to_str(scale),
                         offset=_decay_value_to_str(offset) if offset is not None else None,
                         curve=curve.value if isinstance(curve, _BoostCurve) else curve,
-                        decay_value=decay_value,
+                        decay_value=decay,
                     )
                 )
             ],
@@ -426,7 +426,7 @@ def numeric_decay(
         scale: float,
         offset: Optional[float] = None,
         curve: Optional[Union[_BoostCurve, str]] = None,
-        decay_value: Optional[float] = None,
+        decay: Optional[float] = None,
         weight: Optional[float] = None,
         depth: Optional[int] = None,
     ) -> _Boost:
@@ -435,10 +435,10 @@ def numeric_decay(
         Args:
             property: The numeric property name to compute distance from.
             origin: The origin point (numeric value).
-            scale: Distance from origin where score equals decay_value.
+            scale: Distance from origin where score equals decay.
             offset: Documents within this distance from origin get full score (default 0).
             curve: Decay curve type: `Boost.Curve.EXPONENTIAL` (default), `Boost.Curve.GAUSSIAN`, or `Boost.Curve.LINEAR`.
-            decay_value: Score at scale distance from origin (default 0.5).
+            decay: Score at scale distance from origin (default 0.5).
             weight: Blending weight [0,1] controlling how much the rank affects final scores.
             depth: Number of results to rescore (default 100, max 10000).
         """
@@ -451,7 +451,7 @@ def numeric_decay(
                         scale=float(scale),
                         offset=float(offset) if offset is not None else None,
                         curve=curve.value if isinstance(curve, _BoostCurve) else curve,
-                        decay_value=decay_value,
+                        decay_value=decay,
                     )
                 )
             ],
@@ -510,13 +510,7 @@ def blend(
         for r in ranks:
             for cond in r.conditions:
                 if cond.weight is None and r.weight is not None:
-                    cond = _BoostCondition(
-                        filter=cond.filter,
-                        time_decay=cond.time_decay,
-                        numeric_decay=cond.numeric_decay,
-                        property_value=cond.property_value,
-                        weight=r.weight,
-                    )
+                    cond.weight = r.weight
                 conditions.append(cond)
         return _Boost(conditions=conditions, weight=weight, depth=depth)