return none if last used at is returned with GO's zero date

Author: dudanogueira

mock_tests/test_users.py

@@ -202,3 +202,21 @@ def handler(request: Request) -> Response:
     assert user is not None
     assert user.last_used_time == EXPECTED_LAST_USED_AT
     assert captured["params"].get("includeLastUsedTime") in ("False", "false")
+
+
+def test_get_user_go_zero_time_treated_as_none(
+    weaviate_no_auth_mock: HTTPServer, start_grpc_server: grpc.Server
+) -> None:
+    """Go's zero time (0001-01-01T00:00:00Z) returned by the server should map to None."""
+    data = {**USER_DATA, "lastUsedAt": "0001-01-01T00:00:00Z"}
+    weaviate_no_auth_mock.expect_request("/v1/users/db/test-user").respond_with_response(
+        Response(json.dumps(data), content_type="application/json", status=200)
+    )
+
+    with weaviate.connect_to_local(
+        host=MOCK_IP, port=MOCK_PORT, grpc_port=MOCK_PORT_GRPC
+    ) as client:
+        user = client.users.db.get(user_id="test-user")
+
+    assert user is not None
+    assert user.last_used_time is None

weaviate/users/base.py

@@ -1,4 +1,4 @@
-from datetime import datetime
+from datetime import datetime, timezone
 from typing import Any, Dict, Generic, List, Literal, Optional, Union, cast, overload
 
 from httpx import Response
@@ -21,6 +21,16 @@
 )
 from weaviate.util import _decode_json_response_dict, escape_string
 
+# Go's zero time value, returned by the server when a timestamp is not set
+_GO_ZERO_TIME = datetime(1, 1, 1, 0, 0, tzinfo=timezone.utc)
+
+
+def _parse_last_used_at(value: Optional[str]) -> Optional[datetime]:
+    if value is None:
+        return None
+    dt = datetime.fromisoformat(value.replace("Z", "+00:00"))
+    return None if dt == _GO_ZERO_TIME else dt
+
 
 class _BaseExecutor(Generic[ConnectionType]):
     def __init__(self, connection: ConnectionType):
@@ -468,7 +478,6 @@ def resp(res: Response) -> Optional[UserDB]:
             parsed = _decode_json_response_dict(res, "Get user")
             assert parsed is not None
             created_at = parsed.get("createdAt")
-            last_used_at = parsed.get("lastUsedAt")
             return UserDB(
                 user_id=parsed["userId"],
                 role_names=parsed["roles"],
@@ -479,11 +488,7 @@ def resp(res: Response) -> Optional[UserDB]:
                     if created_at is not None
                     else None
                 ),
-                last_used_time=(
-                    datetime.fromisoformat(last_used_at.replace("Z", "+00:00"))
-                    if last_used_at is not None
-                    else None
-                ),
+                last_used_time=_parse_last_used_at(parsed.get("lastUsedAt")),
                 api_key_first_letters=parsed.get("apiKeyFirstLetters"),
             )
 
@@ -517,11 +522,7 @@ def resp(res: Response) -> List[UserDB]:
                         if (ca := user.get("createdAt")) is not None
                         else None
                     ),
-                    last_used_time=(
-                        datetime.fromisoformat(lua.replace("Z", "+00:00"))
-                        if (lua := user.get("lastUsedAt")) is not None
-                        else None
-                    ),
+                    last_used_time=_parse_last_used_at(user.get("lastUsedAt")),
                     api_key_first_letters=user.get("apiKeyFirstLetters"),
                 )
                 for user in cast(List[WeaviateDBUserRoleNames], parsed)