Fixed fixture scope and addressed linting

Author: saireddythfc

integration/test_collections_sorting.py

@@ -2,37 +2,40 @@
 from integration.conftest import ClientFactory
 
 
-@pytest.fixture(scope="module")
-def client(client_factory: ClientFactory):
+@pytest.fixture
+def sorting_test_client(client_factory: ClientFactory):
     client = client_factory()
     client.collections.delete_all()
     yield client
     client.collections.delete_all()
     client.close()
 
 
-def test_collections_list_all_sorting(client):
+def test_collections_list_all_sorting(sorting_test_client):
     """Test that collections.list_all() returns collections sorted alphabetically by key."""
+
+    client = sorting_test_client
+
     # Create collections with names in non-alphabetical order
     client.collections.create(name="TestCollectionC")
     client.collections.create(name="TestCollectionA")
     client.collections.create(name="TestCollectionB")
 
     # Get all collections
     collections = client.collections.list_all()
-    
+
     # Get the keys and filter only our test collections
     collection_keys = list(collections.keys())
     test_collections = [k for k in collection_keys if k.startswith("TestCollection")]
-    
+
     # Verify they are in alphabetical order
     assert test_collections == sorted(test_collections)
-    
+
     # Test with simple=False as well
     collections = client.collections.list_all(simple=False)
     collection_keys = list(collections.keys())
     test_collections = [k for k in collection_keys if k.startswith("TestCollection")]
     assert test_collections == sorted(test_collections)
-    
+
     # Clean up
     client.collections.delete(["TestCollectionA", "TestCollectionB", "TestCollectionC"])

test/collection/test_collections_sorting.py

@@ -24,7 +24,7 @@ def test_collection_configs_from_json_sorting():
     ):
         # Call the function
         result = _collection_configs_from_json(mock_schema)
-        
+
         # Check that the keys are in alphabetical order
         assert list(result.keys()) == ["CollectionA", "CollectionB", "CollectionC"]
 
@@ -47,6 +47,6 @@ def test_collection_configs_simple_from_json_sorting():
     ):
         # Call the function
         result = _collection_configs_simple_from_json(mock_schema)
-        
+
         # Check that the keys are in alphabetical order
         assert list(result.keys()) == ["CollectionA", "CollectionB", "CollectionC"]

weaviate/collections/classes/config_methods.py

@@ -343,7 +343,9 @@ def _collection_config_from_json(schema: Dict[str, Any]) -> _CollectionConfig:
 
 
 def _collection_configs_from_json(schema: Dict[str, Any]) -> Dict[str, _CollectionConfig]:
-    configs = {schema["class"]: _collection_config_from_json(schema) for schema in schema["classes"]}
+    configs = {
+        schema["class"]: _collection_config_from_json(schema) for schema in schema["classes"]
+    }
     return dict(sorted(configs.items()))